Closed
Bug 1523592
Opened 5 years ago
Closed 5 years ago
Move %TypedArray%.prototype[@@toStringTag] getter from JS to C++
Categories
(Core :: JavaScript: Standard Library, enhancement)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
5.82 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
Follow-up from bug 1518833 comment #2.
Also makes Object.prototype.toString a bit faster when called with TypedArrays, because it's cheaper to call a JSFunction implemented in C++ from C++ code.
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9039776 -
Flags: review?(jorendorff)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9039776 [details] [diff] [review] bug1523592.patch Review of attachment 9039776 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, I remember noticing this code lately and thinking it seemed a bit circuitous.
Attachment #9039776 -
Flags: review?(jorendorff) → review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0049909891557179fae1ac711f5740adc139efb
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbe4b321e60a
Move %TypedArray%.prototype[@@toStringTag] getter from JS to C++. r=jorendorff
Keywords: checkin-needed
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•