1523614 - Right-click does not work in text-based netmonitor sidepanels

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[[e-mail]]

Attachment: 1.jpg

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

Hello I would like ask about right mouse button.I can't copy website links at Web developer tools.

Actual results:

I should copy links at Web developer tools but I can't right button doesn't works

Picture show this issue .

Expected results:

In stable Firefox I can copy but at beta doesn't

Comment 1

[Stefan [:StefanG_QA]]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0 (20190204092937)

I've tested this report on Windows 10 and Ubuntu 18.10 using the latest Nightly, Beta and Fx release builds. I was able to reproduce the mentioned behavior. On the Firefox release build, I am able to successfully copy from DevTools. On the Beta and Nightly, I`m not able to do so. The right mouse click does not trigger the context menu.

Comment 2

[Patrick Brosset <:pbro>]

I can confirm too, on macOS, with Firefox 66 and 67.
It does work with Firefox 65 though. So it seems like a regression.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

This looks like a regression from bug 1495797
@Lenka, can you confirm it?

Honza

Comment 4

[Lenka Pelechova]

(In reply to Jan Honza Odvarko [:Honza] (always need-info? me) from comment #3)

Thanks for the report!

This looks like a regression from bug 1495797
@Lenka, can you confirm it?

Honza

I checked and it comes from this bug . Where <input> was replaced by <span> for the values.

I can try to have a look.
Lenka

Comment 5

[Paarmita Bhargava]

Hey,
I'm and outreachy applicant and would like to work on this project.
Can you please guide me about the issue?
Thanks

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to paarmita1998 from comment #5)

Hey,
I'm and outreachy applicant and would like to work on this project.
Can you please guide me about the issue?

Thanks for the help!

0. Assuming you have downloaded Firefox source already...

1. The Headers panel is implemented in this file:
   https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/HeadersPanel.js

2. The URL is rendered here:
   https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/devtools/client/netmonitor/src/components/HeadersPanel.js#380

3. Here is an example of attaching a context menu to the "Header bar" (displayed at the top of the list of requests in the panel content)
   https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/devtools/client/netmonitor/src/components/RequestListHeader.js#173

Search for onContextMenu in this file to see all interesting places.

4. The menu for the Header is implemented here:
   https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/widgets/RequestListHeaderContextMenu.js

5. You should implement a new menu in widgets/HeadersPanelContextMenu.js (create the file) and attach it to the URL element summaryUrl (mentioned in step #2). Actually, you could pass new argument onContextMenu into the renderSummary method and attach it to all values rendered using renderSummary (i.e. Request URL, Request Method, address, etc.)

6. The menu should have just one item: "Copy".

Comment 7

[Paarmita Bhargava]

Hey,
Does this bug happen in MacOS?

Comment 8

[Paarmita Bhargava]

Okay, I got the issue. Working on it.

Comment 9

[lloan alas:[lloanalas]]

Hi :Paarmita,

How's it going with this bug? Let me know if you need help or anything. I'd like to work on this bug - it would help me get more familiar with the code base.

Thanks!

Comment 10

[Paarmita Bhargava]

Hey,
I'm working on this bug and almost done with it, needs to fix some bugs.

Comment 11

[Patrick Brosset <:pbro>]

Hi Paarmita. Do you still intend to work on this bug? If so, no problem at all if you need more time. But I prefer to ask in case you do not have time anymore, in which case we can make this bug unassigned again so other people can pick it up.

Comment 12

[Patrick Brosset <:pbro>]

Unassigning this bug.

Comment 13

[[e-mail]]

After 1 year my submission this copy still doesn't works.In Poland we said Mozilla has pipe as in my Car .of course we have time .for next year.

Comment 14

[:Harald Kirschner :digitarald]

We are working on refactoring this panel and should also get to this as a follow up.

Same applies to the Timings panel.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 16

[:Harald Kirschner :digitarald]

As prior art, the Changes panel has a good copy menu that also allows copying the current selection. Text-based panels could hook into the same mechanism:

https://searchfox.org/mozilla-central/source/devtools/client/inspector/changes/ChangesContextMenu.js

Comment 17

[[e-mail]]

Firefox 75 nothing change situation is the same .Doesn't works.

Comment 18

[Hubert Boma Manilla (:bomsy)]

This should be fixed now by Bug 1631295.

Comment 19

[Hubert Boma Manilla (:bomsy)]

[e-mail] this should be on nightly.
Please confirm that it works for you.

Thanks

Comment 20

[[e-mail]]

Hubert in 76.0.1 this doesn't works .I do not use Nightly.

Comment 21

[:Harald Kirschner :digitarald]

Bomsy, bug 1631295 partially fixes it for the URL section, but the other fields for Status, Address, etc don't have a context menu.

Comment 22

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1523614 Add copy/copy all context menu for headers summary and properties view r=honza

Add a new context menu for the headers sidepanel with , Copy and Copy all

Comment 23

[Hubert Boma Manilla (:bomsy)]

I've opened a patch to fix

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f46ad63286fa
Add copy/copy all context menu for headers summary and properties view r=nchevobbe

Comment 25

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f46ad63286fa