Closed Bug 1523745 Opened 3 years ago Closed 2 years ago

Kill the `mozbuildinfo` webcommand

Categories

(Developer Services :: Mercurial: hg.mozilla.org, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sheehan, Assigned: lars)

References

Details

Attachments

(1 file)

As suggested in bug 1354791 comment 12, the mozbuildinfo webcommand is busted. Navigating to the URL in a browser greets you with the output of sudo when run by an unprivileged user. Parsing through an Apache httpd access log and searching for mozbuildinfo returns nothing. If there are no more consumers of this endpoint and the implementation is broken, we should kill it.

In the code for this feature in .../hgmo/__init__.py:310, there is a configuration option called hgmo.mozbuildinfoenabled. The comments implies that this a feature that can be enabled on a per repo basis. Rather than just vanishing the admittedly broken feature, perhaps a good first step would be to disable the feature in all repos. This would changed the error message to something less dramatic than an ssh warning. Only after there continues to be no complaints, then remove the feature code.

Assignee: nobody → lars
Depends on: 1529667

Pushed by lars@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/6160c590b717
removed implementation of mozbuild-info r=sheehan

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.