1523755 - Ensure replay.js module is in its own compartment

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Web Replay, task, P5)

Description

[Brian Hackett [Laid off!]]

The replay.js module is loaded in the same compartment as other system code, which prevents it from being able to debug that code. While this isn't a problem with how things are currently used, it prints out a scary error message:

JavaScript error: resource://devtools/server/actors/replay/replay.js, line 45: TypeError: debugger and debuggee must be in different compartments

For now it would be good to avoid printing this error, but this will need to get fixed properly in order to be able to debug system code.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: ignore error

Catch and ignore errors related to adding same-compartment debuggees.

Comment 2

[Logan Smyth [:loganfsmyth]]

Comment on attachment 9039909 [details] [diff] [review]
ignore error

Review of attachment 9039909 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/server/actors/replay/replay.js
@@ +45,5 @@
> +    dbg.addDebuggee(global);
> +  } catch (e) {
> +    // Ignore errors related to adding a same-compartment debuggee.
> +    // See bug 1523755.
> +    if (!/debugger and debuggee must be in different compartments/.test("" + e)) {

Are these messages localized at all? Do we have to worry about different error strings in that context?

Comment 3

[Brian Hackett [Laid off!]]

(In reply to Logan Smyth [:loganfsmyth] from comment #2)

Comment on attachment 9039909 [details] [diff] [review]
ignore error

Review of attachment 9039909 [details] [diff] [review]:

::: devtools/server/actors/replay/replay.js
@@ +45,5 @@

• dbg.addDebuggee(global);
• } catch (e) {
• // Ignore errors related to adding a same-compartment debuggee.
• // See bug 1523755.
• if (!/debugger and debuggee must be in different compartments/.test("" + e)) {

Are these messages localized at all? Do we have to worry about different
error strings in that context?

This is a spidermonkey error (JSMSG_DEBUG_SAME_COMPARTMENT) which I don't think is localized anywhere.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/548e9d90a38f
Ignore same-compartment debuggee errors in replay.js, r=lsmyth.

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/548e9d90a38f