Closed Bug 1523761 Opened 5 years ago Closed 5 years ago

Move the syncedTabs strings from browser.dtd to fluent

Categories

(Firefox :: Sync, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: Gijs, Assigned: chengy12, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The synced tabs sidebar ( https://searchfox.org/mozilla-central/source/browser/components/syncedtabs/sidebar.xhtml ) uses browser.dtd for its strings:

https://searchfox.org/mozilla-central/rev/c07aaf12f13037c1f5a343d31f8291549e57373f/browser/locales/en-US/chrome/browser/browser.dtd#891-924

It should instead have its own FTL file.

The tricky bit is that some strings are used in the context menu for this sidebar in browser.xul .

To make those work, we'll need to insert the FTL file dynamically when the sidebar is shown. We can do this by calling MozXULElement.insertFTLIfNeeded() on the toplevel window from within sidebar.js ( https://searchfox.org/mozilla-central/source/browser/components/syncedtabs/sidebar.js ) when the page loads.

Assignee: nobody → chengy12
Status: NEW → ASSIGNED
Priority: -- → P2
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c0996caf797f
Move the syncedTabs strings from browser.dtd to fluent, r=Gijs,flod
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd9f4d421007
Backed out changeset c0996caf797f for bc failures in browser/components/customizableui/test/browser_947914_button_history.js CLOSED TREE
Depends on: 1536633
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ff28f10d2759
Move the syncedTabs strings from browser.dtd to fluent, r=Gijs,flod
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Flags: needinfo?(chengy12)
You need to log in before you can comment on or make changes to this bug.