1523762 - Fix usage of CC_TYPE in SeaMonkey build files.

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Frank-Rainer Grahl (:frg)]

Bug 1394734 was not ported or the below error wouldn't have happened.

There are a few other places which need a cleanup too. Basically needs build fixes from Bug 1333003 part 8 and Bug 1031352.

+++ This bug was initially created as a clone of Bug #1522761 +++

Windows opt builds broken on 2019-01-24 - lld-link: error: undefined symbol: _WinMain@16

Last successful build with
M-C 2c5eb9d8b8e2680e7ff3d8fe2714bfd78e
First bustage with
M-C 2d056ed15129ea779eda14a04615906b3b

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2c5eb9d8b8e2680e7ff3d8fe2714bfd78e&tochange=2d056ed15129ea779eda14a04615906b3b

00:06:09 INFO - lld-link: warning: ignoring unknown argument: -RELEASE
00:06:09 INFO - lld-link: error: undefined symbol: _WinMain@16
00:06:09 INFO - >>> referenced by f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:102
00:06:09 INFO - >>> msvcrt.lib(exe_winmain.obj):("int __cdecl invoke_main(void)" (?invoke_main@@YAHXZ))
00:06:09 INFO - >>> referenced by f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:288
00:06:09 INFO - >>> msvcrt.lib(exe_winmain.obj):("int __cdecl __scrt_common_main_seh(void)" (?__scrt_common_main_seh@@YAHXZ))

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1523762-cxx-suite-cc.patch

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1523762-cxx-suite-60.patch

SeaMonkey 2.57 version

Comment 3

[Ian Neal]

Comment on attachment 9039917 [details] [diff] [review]
1523762-cxx-suite-cc.patch

r=me

Comment 4

[Ian Neal]

Comment on attachment 9039918 [details] [diff] [review]
1523762-cxx-suite-60.patch

r/a=me if required

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5ad1c6f20efc
Fix usage of CC_TYPE in SeaMonkey build files. r=IanN

Comment 6

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/e570ac49cced28ef49d7921cb15ac0fe05b13ec3

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9039918 [details] [diff] [review]
1523762-cxx-suite-60.patch

Target 2.53.1 beta 1
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/32ad5105ae9b32312c90f9aed64ae593a8380b2e