1523846 - Build busted 2019-01-30; probably bug 1478124

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

ERROR - /builds/worker/workspace/build/src/comm/mailnews/base/src/nsMsgMailSession.cpp:566:21: error: use of undeclared identifier 'NS_APPSTARTUP_CONTRACTID'
INFO - do_GetService(NS_APPSTARTUP_CONTRACTID);
INFO - ^
INFO - 1 error generated.
INFO - /builds/worker/workspace/build/src/config/rules.mk:1117: recipe for target 'nsMsgMailSession.o' failed
ERROR - make[4]: *** [nsMsgMailSession.o] Error 1

ERROR - /builds/worker/workspace/build/src/comm/mailnews/compose/src/nsURLFetcher.cpp:316:52: error: use of undeclared identifier 'NS_URI_LOADER_CONTRACTID'
INFO - nsCOMPtr<nsIURILoader> pURILoader (do_GetService(NS_URI_LOADER_CONTRACTID));
INFO - ^
INFO - 1 error generated.
INFO - /builds/worker/workspace/build/src/config/rules.mk:1117: recipe for target 'nsURLFetcher.o' failed
ERROR - make[4]: *** [nsURLFetcher.o] Error 1

Busted on this Try push: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a2f8bb9fbaba96157048b95bebff2cf4aae9fade

Comment 1

[Jorg K (CEST = GMT+2)]

OK, compile error is
error: use of undeclared identifier 'NS_APPSTARTUP_CONTRACTID'

That used to be defined in nsToolkitCompsCID.h but I see this:
https://hg.mozilla.org/mozilla-central/rev/6a412d8f24dbd09f001034a8ad369c40d9ebe7b0#l1.12

So it's replaced with #include "mozilla/Components.h".

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1523846-nsToolkitCompsCID.patch

This should do it, a little different to what I first assumed.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9040039 [details] [diff] [review]
1523846-nsToolkitCompsCID.patch

Review of attachment 9040039 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/edd878b75ea3
Port bug 1478124: Replace use of NS_APPSTARTUP_CONTRACTID and NS_URI_LOADER_CONTRACTID. r=mkmelin

Comment 5

[Jorg K (CEST = GMT+2)]

Hmm, Mac is still busted:
mailnews/base/src/nsMessengerOSXIntegration.mm:388:59: error: use of undeclared identifier 'NS_ALERTSERVICE_CONTRACTID'

Strange since NS_ALERTSERVICE_CONTRACTID is also used for Windows:
https://searchfox.org/comm-central/search?q=NS_ALERTSERVICE_CONTRACTID&case=false&regexp=false&path=

Ah, no, only in SM: #ifndef MOZ_THUNDERBIRD

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1523846-NS_ALERTSERVICE_CONTRACTID.patch

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ebced95d166
Port bug 1478124: Replace use of NS_ALERTSERVICE_CONTRACTID. r=mkmelin

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c35a38ef52da
Follow-up: set 'rv' depending on alerts service allocation. rs=bustage-fix

Comment 9

[Jorg K (CEST = GMT+2)]

You can't see it in those changesets, but the damn rv is used further down and even returned :-(