Testing: replace test-also-wasm* directives by test-also
Categories
(Core :: JavaScript: WebAssembly, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(1 file)
|
23.54 KB,
patch
|
lth
:
review+
|
Details | Diff | Splinter Review |
We have a general mechanism to add shell flags switches to the test harness, with test-also=--wasm-compiler=baseline. We should use this in place of test-also-wasm-baseline et al. There are checks in the lib/jittests.py library that asm.js/wasm is enabled controlling the effect of these flags, but I think the hasWasmSupport() test implicitly included thanks to directives.txt files should cover that properly.
|
Assignee | |
Comment 1•5 years ago
|
||
Let's see how this works out: https://treeherder.mozilla.org/#/jobs?repo=try&revision=996be03409154b3072d0f0d6e24fc717018c5f0c
|
||
Comment 2•5 years ago
|
||
There's an annoying restriction in --test-also that it takes only one switch, and multiple --test-also commands will be interpreted separately. Thus --test-also=--wasm-compiler=baseline --test-also=--wasm-gc does not do what you want it to do, namely, test the combination of those switches; you get tests for one switch, then tests for the other switch. It's possible to work around with this in part using --test-join, but the flags provided by --test-join are provided to /all/ tests, they're never absent.
So for bonus points, make --test-also='--wasm-compiler=baseline --wasm-gc' legal syntax...
|
|
Assignee | |
Comment 3•5 years ago
|
||
As discussed on irc, this would be a new feature to allow more elaborate switches, and I've had a patch ready, so we can defer this feature to a follow-up bug.
|
|
||
Comment 4•5 years ago
|
||
Comment on attachment 9040343 [details] [diff] [review] 1523876.patch Review of attachment 9040343 [details] [diff] [review]: ----------------------------------------------------------------- Nice simplification of the python code.
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8bd53bf9a691 Replace uses of test-also-wasm-compiler by test-also in wasm tests; r=lth
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•