Closed Bug 1523876 Opened 1 year ago Closed 1 year ago

Testing: replace test-also-wasm* directives by test-also

Categories

(Core :: Javascript: WebAssembly, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

Details

Attachments

(1 file)

We have a general mechanism to add shell flags switches to the test harness, with test-also=--wasm-compiler=baseline. We should use this in place of test-also-wasm-baseline et al. There are checks in the lib/jittests.py library that asm.js/wasm is enabled controlling the effect of these flags, but I think the hasWasmSupport() test implicitly included thanks to directives.txt files should cover that properly.

There's an annoying restriction in --test-also that it takes only one switch, and multiple --test-also commands will be interpreted separately. Thus --test-also=--wasm-compiler=baseline --test-also=--wasm-gc does not do what you want it to do, namely, test the combination of those switches; you get tests for one switch, then tests for the other switch. It's possible to work around with this in part using --test-join, but the flags provided by --test-join are provided to /all/ tests, they're never absent.

So for bonus points, make --test-also='--wasm-compiler=baseline --wasm-gc' legal syntax...

Attached patch 1523876.patchSplinter Review

As discussed on irc, this would be a new feature to allow more elaborate switches, and I've had a patch ready, so we can defer this feature to a follow-up bug.

Assignee: nobody → bbouvier
Status: NEW → ASSIGNED
Attachment #9040343 - Flags: review?(lhansen)
Comment on attachment 9040343 [details] [diff] [review]
1523876.patch

Review of attachment 9040343 [details] [diff] [review]:
-----------------------------------------------------------------

Nice simplification of the python code.
Attachment #9040343 - Flags: review?(lhansen) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8bd53bf9a691
Replace uses of test-also-wasm-compiler by test-also in wasm tests; r=lth
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Depends on: 1607079
You need to log in before you can comment on or make changes to this bug.