Dynamic import in HTML event handlers should be relative to the document
Categories
(Core :: DOM: Core & HTML, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
()
Details
Attachments
(2 files)
1.55 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
11.00 KB,
patch
|
Details | Diff | Splinter Review |
The spec is changing the original behaviour of using the current script when the handler was compiled as the referencing script to using the null script. As noted, the original behaviour was path dependent and confusing.
Assignee | ||
Comment 1•5 years ago
|
||
To implement this we need to remove the association between newly compiled event handlers and the current active script.
Assignee | ||
Comment 2•5 years ago
|
||
Test code changes related to the above patch.
I'm planning to get these reviewed via the WPT github repo.
Comment 3•5 years ago
|
||
Comment on attachment 9041474 [details] [diff] [review] bug1523899-event-handler-script Yes, the old behavior was bizarre. Do we need the same with setTimeout? Maybe not.
Assignee | ||
Comment 4•5 years ago
|
||
(In reply to Olli Pettay [:smaug] (massive needinfo queue, ping on IRC on anything urgent) from comment #3)
Do we need the same with setTimeout? Maybe not.
I think the setTimeout behaviour makes sense as it is: the import is relative to the script that sets the timeout.
Assignee | ||
Comment 5•5 years ago
|
||
I'm going to land this with updated test expectations for the tests that will now fail.
I've created a PR for the test updates here: https://github.com/web-platform-tests/wpt/pull/15251
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4f266277d3b8 Dynamic import in event handlers should be relative to the document r=smaug
Comment 7•5 years ago
|
||
Backed out for wpt failures on string-compilation-base-url-external-classic.html.
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/292897fbc609fbe6c8c2a8f88ea81dccd6f7b8b5
Push link: https://hg.mozilla.org/integration/mozilla-inbound/rev/4f266277d3b82cfb492d2c807aa76c198e938572
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226475053&repo=mozilla-inbound&lineNumber=12308
Comment 8•5 years ago
|
||
There were also wpt failures on IndexedDB/idb-explicit-commit.any.worker.html
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226478891&repo=mozilla-inbound&lineNumber=1405
Assignee | ||
Comment 9•5 years ago
|
||
Looks like I messed up updating those test expectations.
Comment 10•5 years ago
|
||
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d49c8904e838 Dynamic import in event handlers should be relative to the document r=smaug
Comment 11•5 years ago
|
||
bugherder |
Description
•