1524001 - manifest.icons is defined as string

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Changing it to IconPath for schema validation.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1524001 update manifest to validate manifest.icons, r?kmag

Comment 2

[Daniel Veditz [:dveditz]]

Shane verified that javascript: urls don't run (error Illegal URL) so this seems to result in a potential for an unwanted network ping but not much worse.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for test_ext_management.js failures:

https://hg.mozilla.org/integration/autoland/rev/1b1ecaa655a3e0a8481c538c95bb996672c58de0

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Cretry&group_state=expanded&revision=2e087a05389832843f3e844d277947e40a7cf187
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=225893997&repo=autoland

[task 2019-02-04T16:37:15.273Z] 16:37:15 INFO - TEST-PASS | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_ext_management.js | test_management_get_self_complete - [test_management_get_self_complete : 68] getSelf returned the expected icon size - 16 == 16
[task 2019-02-04T16:37:15.274Z] 16:37:15 WARNING - TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_ext_management.js | test_management_get_self_complete - [test_management_get_self_complete : 69] getSelf returned the expected icon url - "moz-extension://05c794f4-8dcc-4e12-9713-cd68bcf8b3db/icons/icon-16.png" == "icons/icon-16.png"
[task 2019-02-04T16:37:15.275Z] 16:37:15 INFO - /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_ext_management.js:test_management_get_self_complete:69
[task 2019-02-04T16:37:15.278Z] 16:37:15 INFO - exiting test
[task 2019-02-04T16:37:15.278Z] 16:37:15 INFO - Unexpected exception NS_ERROR_ABORT:
[task 2019-02-04T16:37:15.280Z] 16:37:15 INFO - _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:740:9
[task 2019-02-04T16:37:15.281Z] 16:37:15 INFO - do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:847:5
[task 2019-02-04T16:37:15.282Z] 16:37:15 INFO - Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:54:5
[task 2019-02-04T16:37:15.284Z] 16:37:15 INFO - proto.report@resource://testing-common/Assert.jsm:213:5
[task 2019-02-04T16:37:15.285Z] 16:37:15 INFO - equal@resource://testing-common/Assert.jsm:249:3
[task 2019-02-04T16:37:15.287Z] 16:37:15 INFO - test_management_get_self_complete@/builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/test_ext_management.js:69:5
[task 2019-02-04T16:37:15.289Z] 16:37:15 INFO - asyncrun_next_test/_run_next_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:1435:22
[task 2019-02-04T16:37:15.290Z] 16:37:15 INFO - async_run_next_test@/builds/worker/workspace/build/tests/xpcshell/head.js:1435:10
[task 2019-02-04T16:37:15.292Z] 16:37:15 INFO - run@/builds/worker/workspace/build/tests/xpcshell/head.js:686:9
[task 2019-02-04T16:37:15.294Z] 16:37:15 INFO - _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:224:3
[task 2019-02-04T16:37:15.295Z] 16:37:15 INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:527:5
[task 2019-02-04T16:37:15.297Z] 16:37:15 INFO - @-e:1:1
[task 2019-02-04T16:37:15.299Z] 16:37:15 INFO - exiting test

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1076c6c6a18584c3561d63c080a6d478b0547fd7

Comment 5

[Shane Caraveo (:mixedpuppy)]

patch updated with fix for failure.

Comment 6

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a4db765d9b882fb8856048480107b44bdd0e5dad

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/007300419d20ad893db8d006302b04534bb8bed3
https://hg.mozilla.org/mozilla-central/rev/007300419d20

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something that can ride the trains or should it be nominated for Beta backport?

Comment 9

[Shane Caraveo (:mixedpuppy)]

I think it's probably fine to ride the train.