Closed Bug 1524021 Opened 2 years ago Closed 2 years ago

Display message in nightly about dark theme not functional for pocket newtab view

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 67
Iteration:
67.1 - Jan 28 - Feb 10
Tracking Status
firefox66 --- unaffected
firefox67 --- verified

People

(Reporter: pdahiya, Assigned: pdahiya)

References

Details

(Keywords: github-merged)

Attachments

(2 files)

With https://bugzilla.mozilla.org/show_bug.cgi?id=1523703, Nightly will have pocket new tab view pref on by default.

Scope of this issue is to show messaging on Nightly letting dark theme users know that pocket new tab view doesn't support dark theme.

Blocks: 1523703
Blocks: 1512725
Assignee: nobody → pdahiya

Synched up with Kate and messaging template similar to manual migration on new tab might work (See attached). If needed, we should be able to show a button against the messaging that can disable pocket new tab view. Including Wolasi for design feedback. Thanks!

Flags: needinfo?(wkonu)

Does display this disclosure require additional visual design work, or do we get it for free? And is this just for Nightly users or will we display in user-facing experiments?

Flags: needinfo?(wkonu)

(In reply to Wolasi from comment #3)

Does display this disclosure require additional visual design work, or do we get it for free?

We should be able to reuse most of the design work here. We do need new message strings, button label and may be vet out any edge cases such as when both manual migration and dark theme message displays in nightly. NI Kate to help clarify if this edge case is possible?

And is this just for Nightly users or will we display in user-facing experiments?

My understanding, this is planned for nightly users for now.

Flags: needinfo?(khudson)

https://github.com/mozilla/activity-stream/blob/master/content-src/components/Base/Base.jsx#L184

We are not showing manual migration message in discovery stream experience. Clearing NI for Kate. Thanks!

Flags: needinfo?(khudson)
Iteration: --- → 67.1 - Jan 28 - Feb 10
Priority: -- → P1
Blocks: 1525452
Status: NEW → RESOLVED
Closed: 2 years ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Pre-req:

  1. browser.newtabpage.activity-stream.discoverystream.optOut.0 should be set to false
  2. browser.newtabpage.activity-stream.discoverystream.config pref enabled property should be false

How to test:
1.Go to about:addons -> Themes -> Select Dark Theme
2. Open New Tab. It should open in dark mode
3. go to about:config
4. search for discoverystream.config and set preference enabled value as true
5. Navigate back to new tab or open a new tab. With discovery steam enabled new tab should not open in dark mode and should display message "This version of New Tab doesn't support dark mode yet."
7. Click on Got it button should hide the message and subsequent load of new tab shouldn't display dark mode message
8. Click on Use older version should switch new tab view to older activity stream version shown in dark mode.

NI Brahmini for helping QA this fix. Thanks!

Flags: needinfo?(bnagabandi)

Punam,

Seems like the behaviors are not as expected.

Tracking here : https://bugzilla.mozilla.org/show_bug.cgi?id=1526864

Please let me know if I'm wrong, thanks.

Flags: needinfo?(bnagabandi) → needinfo?(pdahiya)

(In reply to Brahmini Nagabandi from comment #10)

Punam,

Seems like the behaviors are not as expected.

Tracking here : https://bugzilla.mozilla.org/show_bug.cgi?id=1526864

Please let me know if I'm wrong, thanks.

It seems dark mode message is working as expected. I have updated bug 1526864 with comments,
please let me know if there are still questions and we can try to answer over slack/vidyo. Thanks!

Flags: needinfo?(pdahiya) → needinfo?(bnagabandi)

QA Results:

Tested on :

FF Nightly version : 67.0a1 (2019-02-19)
OS : Mac and Windows 10 Pro

Works as expected.

Closing as verified.

Flags: needinfo?(bnagabandi)
Status: RESOLVED → VERIFIED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.