Closed Bug 1524194 Opened 1 year ago Closed 10 months ago

linux_syscall_support.h: error: listing the stack pointer register 'rsp' in a clobber list is deprecated

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed
firefox68 --- wontfix
firefox69 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Build with gcc-9

In file included from /root/firefox-gcc-last/toolkit/crashreporter/breakpad-client/linux/crash_generation/crash_generation_client.cc:40,
                 from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/toolkit/crashreporter/breakpad-client/linux/Unified_cpp_linux0.cpp:2:
/root/firefox-gcc-last/toolkit/crashreporter/google-breakpad/src/third_party/lss/linux_syscall_support.h: In member function 'bool google_breakpad::ExceptionHandler::GenerateDump(google_breakpad::ExceptionHandler::CrashContext*)':
/root/firefox-gcc-last/toolkit/crashreporter/google-breakpad/src/third_party/lss/linux_syscall_support.h:2408:75: error: listing the stack pointer register 'rsp' in a clobber list is deprecated [-Werror=deprecated]
 2408 |                              : "rsp", "memory", "r8", "r10", "r11", "rcx");
      |                                                                           ^
/root/firefox-gcc-last/toolkit/crashreporter/google-breakpad/src/third_party/lss/linux_syscall_support.h:2408:75: note: the value of the stack pointer after an 'asm' statement must be the same as it was before the statement
cc1plus: all warnings being treated as errors

Looks like this just got fixed upstream:
https://chromium.googlesource.com/linux-syscall-support/+/8048ece6c16c91acfe0d36d1d3cc0890ab6e945c

Feel free to cherry-pick that patch into m-c.

Assignee: nobody → sledru

thanks Ted!

Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0af61750393
Do not add stack pointer to clobber list r=ted
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

This is back because bug 1538810 reverted this change.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f54952905cb1
Do not add stack pointer to clobber list r=gsvelto
Status: REOPENED → RESOLVED
Closed: 1 year ago10 months ago
Resolution: --- → FIXED

Change the status for beta to have the same as nightly and release.
For more information, please visit auto_nag documentation.

You need to log in before you can comment on or make changes to this bug.