1524255 - dark theme - poor differentiation of unread messages

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[William]

Attachment: ticket_thunderbird_theme.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce:

I use a dark theme and display list of messages

Actual results:

with a dark theme the differentiation of unread messages is poor

Expected results:

unread messages should be of another color, or the choice could be given in the configuration

Comment 1

[Wayne Mery (:wsmwk)]

Another linux Theme issue?

Comment 2

[Richard Marti (:Paenglab)]

William, is this with a dark Linux theme or with the TB Dark theme?

Comment 3

[William]

I'm using gnome 3.28.2 (centos 7) and I don't have a theme on my Desktop Environments

This issue is for TB Dark by Mozilla

Comment 4

[William]

Attachment: probleme dark mode chat

I found another problem with this theme, the chat history does not show

Comment 5

[Richard Marti (:Paenglab)]

(In reply to William from comment #4)

Created attachment 9040404 [details]
probleme dark mode chat

I found another problem with this theme, the chat history does not show

This should be fixed in the next version.

Comment 6

[Peter Kihlstedt :peki]

Confirmed with Thunderbird Daily on Windows 10 during bugday.

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to Peter Kihlstedt :peki from comment #6)

Confirmed with Thunderbird Daily on Windows 10 during bugday.

Richard, does this conflict with your comment 5?

Comment 8

[Richard Marti (:Paenglab)]

I think, the confirmation is about the differentiation of unread messages and not the chat history

Comment 9

[Jorg K (CEST = GMT+2)]

What's the status here after the latest lot of theme changes for the dark theme?

Comment 10

[Richard Marti (:Paenglab)]

No change. Alessandro, what do you think to make the unread messages bolder as they are now, like font-weight: 900; ? Then they stand out more.

Comment 11

[Alessandro Castellani [:aleca]]

Are those message rows already at #FFFFFF? If not, unread messages should have that full white to stand out even more.
Let's try with a thicker font-weight, but I'm not sure if it could affects readability.
Also, changing the unread icon to use an SVG with a bright colour and a light drop shadow might help, instead of that tiny and blurry green PNG.
That's one of the downfalls of having a super tight text list, everything blends together.

Comment 12

[Richard Marti (:Paenglab)]

Attachment: 1524255-dark-theme-unread-indicator.patch

The normal text is rgb(249, 249, 250) and now the unread rgb(255, 255, 255). Do you think, this is enough?

Comment 13

[Alessandro Castellani [:aleca]]

Comment on attachment 9085571 [details] [diff] [review]
1524255-dark-theme-unread-indicator.patch

Review of attachment 9085571 [details] [diff] [review]:
-----------------------------------------------------------------

It helps, but I don't see it making a huge difference unfortunately.
The font-weight to 900 also makes it hard to read, so that's a no go.

I wonder if highlighting the entire row with a darker tone would make it pop more, but that may introduce some quirky behavior with selection and highlight if we're not careful.
What do you think?

I'm giving this a r+ because it improves a bit the situation, but it doesn't completely solve the problem.

Comment 14

[Richard Marti (:Paenglab)]

Yes, I think, this is all we can do.

Jörg, the commit message has errors. Can you fix it while landing to:

Bug 1524255 - [dark theme] Make the unread message text bright white for better differentiation. r=aleca

or to a better one if you don't like it.

Comment 15

[Jorg K (CEST = GMT+2)]

I can, of course. Any uplifts here?

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/daa65bc8dffd
[dark theme] Make unread message text bright white for better differentiation. r=aleca

Comment 17

[Richard Marti (:Paenglab)]

Comment on attachment 9085571 [details] [diff] [review]
1524255-dark-theme-unread-indicator.patch

It applies with with a fuzzing warning on ESR.

Comment 18

[Jorg K (CEST = GMT+2)]

Comment on attachment 9085571 [details] [diff] [review]
1524255-dark-theme-unread-indicator.patch

On trunk, too ;-)
$ hg qpush
applying 1524255-dark-theme-unread-indicator.patch
patching file mail/themes/shared/mail/mailWindow1.css
Hunk #1 succeeded at 36 with fuzz 1 (offset 0 lines).
now at: 1524255-dark-theme-unread-indicator.patch

Comment 19

[Richard Marti (:Paenglab)]

My bad, I had bug 1017904 applied first. :-(

Comment 20

[Jorg K (CEST = GMT+2)]

TB 69 beta 3:
https://hg.mozilla.org/releases/comm-beta/rev/58961ed683507cf99907e4626519d7074242df8b

Comment 21

[Jorg K (CEST = GMT+2)]

TB 68.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/f7b8ee14d63ef1c4202212319a7242f331b5951f