Closed Bug 1524255 Opened Last year Closed 5 months ago

dark theme - poor differentiation of unread messages

Categories

(Thunderbird :: Theme, defect)

defect
Not set

Tracking

(thunderbird_esr6868+ fixed, thunderbird69 fixed, thunderbird70 fixed)

RESOLVED FIXED
Thunderbird 70.0
Tracking Status
thunderbird_esr68 68+ fixed
thunderbird69 --- fixed
thunderbird70 --- fixed

People

(Reporter: willouuu, Assigned: Paenglab)

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce:

I use a dark theme and display list of messages

Actual results:

with a dark theme the differentiation of unread messages is poor

Expected results:

unread messages should be of another color, or the choice could be given in the configuration

Another linux Theme issue?

William, is this with a dark Linux theme or with the TB Dark theme?

I'm using gnome 3.28.2 (centos 7) and I don't have a theme on my Desktop Environments

This issue is for TB Dark by Mozilla

Attached image probleme dark mode chat

I found another problem with this theme, the chat history does not show

(In reply to William from comment #4)

Created attachment 9040404 [details]
probleme dark mode chat

I found another problem with this theme, the chat history does not show

This should be fixed in the next version.

Confirmed with Thunderbird Daily on Windows 10 during bugday.

Status: UNCONFIRMED → NEW
Ever confirmed: true

(In reply to Peter Kihlstedt :peki from comment #6)

Confirmed with Thunderbird Daily on Windows 10 during bugday.

Richard, does this conflict with your comment 5?

Flags: needinfo?(richard.marti)

I think, the confirmation is about the differentiation of unread messages and not the chat history

Flags: needinfo?(richard.marti)

What's the status here after the latest lot of theme changes for the dark theme?

Flags: needinfo?(richard.marti)

No change. Alessandro, what do you think to make the unread messages bolder as they are now, like font-weight: 900; ? Then they stand out more.

Flags: needinfo?(richard.marti) → needinfo?(alessandro)

Are those message rows already at #FFFFFF? If not, unread messages should have that full white to stand out even more.
Let's try with a thicker font-weight, but I'm not sure if it could affects readability.
Also, changing the unread icon to use an SVG with a bright colour and a light drop shadow might help, instead of that tiny and blurry green PNG.
That's one of the downfalls of having a super tight text list, everything blends together.

Flags: needinfo?(alessandro)

The normal text is rgb(249, 249, 250) and now the unread rgb(255, 255, 255). Do you think, this is enough?

Assignee: nobody → richard.marti
Attachment #9085571 - Flags: review?(alessandro)
Comment on attachment 9085571 [details] [diff] [review]
1524255-dark-theme-unread-indicator.patch

Review of attachment 9085571 [details] [diff] [review]:
-----------------------------------------------------------------

It helps, but I don't see it making a huge difference unfortunately.
The font-weight to 900 also makes it hard to read, so that's a no go.

I wonder if highlighting the entire row with a darker tone would make it pop more, but that may introduce some quirky behavior with selection and highlight if we're not careful.
What do you think?

I'm giving this a r+ because it improves a bit the situation, but it doesn't completely solve the problem.
Attachment #9085571 - Flags: review?(alessandro) → review+

Yes, I think, this is all we can do.

Jörg, the commit message has errors. Can you fix it while landing to:

Bug 1524255 - [dark theme] Make the unread message text bright white for better differentiation. r=aleca

or to a better one if you don't like it.

Keywords: checkin-needed

I can, of course. Any uplifts here?

Target Milestone: --- → Thunderbird 70.0

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/daa65bc8dffd
[dark theme] Make unread message text bright white for better differentiation. r=aleca

Status: NEW → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Comment on attachment 9085571 [details] [diff] [review]
1524255-dark-theme-unread-indicator.patch

It applies with with a fuzzing warning on ESR.
Attachment #9085571 - Flags: approval-comm-esr68?
Attachment #9085571 - Flags: approval-comm-beta?
Comment on attachment 9085571 [details] [diff] [review]
1524255-dark-theme-unread-indicator.patch

On trunk, too ;-)
$ hg qpush
applying 1524255-dark-theme-unread-indicator.patch
patching file mail/themes/shared/mail/mailWindow1.css
Hunk #1 succeeded at 36 with fuzz 1 (offset 0 lines).
now at: 1524255-dark-theme-unread-indicator.patch
Attachment #9085571 - Flags: approval-comm-beta? → approval-comm-beta+

My bad, I had bug 1017904 applied first. :-(

Attachment #9085571 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.