Whatsapp emoji list isn't correctly clipped
Categories
(Core :: Graphics: WebRender, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox65 | --- | unaffected |
firefox66 | --- | fixed |
firefox67 | --- | fixed |
People
(Reporter: Tobias.Marty, Assigned: kats)
References
()
Details
(Keywords: regression)
Attachments
(4 files)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
Steps to reproduce:
Updated Nightly to 67.0a1 (2019-01-31) (64-bit).
Opened emoji list in Whatsapp Web chat window.
Actual results:
When scrolling in the emoji list the emojis go "out of bounds" of their designated window area and overlay the chat.
Comment 1•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Looks like the emojis are inside a transform (possibly multiple nested transforms) and the clip chain isn't getting applied properly on the stacking contexts for the transforms. Attached WIP fixes it, but I dunno if it breaks other stuff.
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Bunch of orange, but they all look like fuzzable differences. On Linux at least. So that's good news.
Assignee | ||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
(Scrolling the playlist: https://www.youtube.com/watch?v=8JnfIa84TnU&list=RD8JnfIa84TnU)
Assignee | ||
Comment 8•6 years ago
|
||
On Mac and Windows the differences are also fuzzable but there's a lot more due to text antialiasing differences. Fixing this up is going to be quite tedious. For now I'll back out the regressing changes.
Assignee | ||
Comment 10•6 years ago
|
||
WhatsApp Web has emojis in divs with border-radius, inside a transform,
inside a scrollframe. The patch in bug 1523776 broke the clipping in
that scrolling the scrollframe would make the emoji visible outside the
scrollframe. This reftest replicates that scenario.
Comment 12•6 years ago
|
||
Comment 13•6 years ago
|
||
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=225322703&repo=mozilla-inbound&lineNumber=10162
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/f0f368542bf7c22c9b05d625a6afb3a197a40235
Assignee | ||
Comment 14•6 years ago
|
||
This one is only failing on linux32 debug where we're still running non-e10s tests (i.e. this needs a skip-if(!asyncPan))
Comment 15•6 years ago
|
||
Comment 16•6 years ago
|
||
bugherder |
Updated•6 years ago
|
Assignee | ||
Comment 17•6 years ago
|
||
Would like to uplift this, a=test-only
Assignee | ||
Comment 20•6 years ago
|
||
Description
•