1524283 - Remove all code related to updatedSource in client and server

Status: RESOLVED DUPLICATE of bug 1547314

(DevTools :: Debugger, task, P3)

Description

[Alexandre Poirot [:ochameau]]

We do send the "updatedSource" event on the parent of the thread actor, i.e. the target actor. But that will prevent easily converting the thread client to a front and introduces confusion between the two actors/fronts.

We now have a better code on the client side, with the refactoring of target classes, to correctly listen for events on the thread client.

Comment 1

[Alexandre Poirot [:ochameau]]

While working on bug 1269919, we realized that updatedSource event wasn't correctly handled on the frontend side.
That doesn't break any test. So I'm wondering how useful this event really is?

We do send this event from here:
https://searchfox.org/mozilla-central/rev/4587d146681b16ff9878a6fdcba53b04f76abe1d/devtools/server/actors/thread.js#1760-1766

This is supposed to be translated into source-updated event on the target over here:
https://searchfox.org/mozilla-central/rev/4587d146681b16ff9878a6fdcba53b04f76abe1d/devtools/shared/fronts/targets/target-mixin.js#395-399

But this is broken as we are missing "updatedSource" event declaration in target's protocol.js specification file:
https://searchfox.org/mozilla-central/rev/4587d146681b16ff9878a6fdcba53b04f76abe1d/devtools/shared/specs/targets/browsing-context.js#139-142
(we have newSource but miss updatedSource)

source-updated is only used by the source map service:
https://searchfox.org/mozilla-central/rev/4587d146681b16ff9878a6fdcba53b04f76abe1d/devtools/client/framework/source-map-url-service.js#117

Logan, Do you have any idea how useful the source map service is nowadays? Any idea what is the updatesSource event sent by the actor and how it could impact the source map service?

Comment 2

[Alexandre Poirot [:ochameau]]

Actually, I haven't looked at the server side of this story.
Logan just told me on phabricator that this updatedSource events is never fired on TabSources and so it looks like both client and server side is a dead piece of code:
https://searchfox.org/mozilla-central/search?q=updatedSource&case=false&regexp=false&path=

Comment 3

[Shivam Singhal [ :championshuttler ]]

Hi @Jason can I take this up?

Thanks

Comment 4

[Jason Laster [:jlast]]

Sure :championshuttler.

Comment 5

[Jason Laster [:jlast]]

How is it going Shivam? Anything we can help with?