Removing truncation + character counts

VERIFIED FIXED in Firefox 66

Status

()

defect
P1
normal
VERIFIED FIXED
6 months ago
24 days ago

People

(Reporter: gsuntop, Assigned: gsuntop)

Tracking

({github-merged})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66+ verified, firefox67 verified)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Enforce new character counts:

Based on a conversation with Wolasi and Nick, we've decided to keep line clamping but remove truncation and character counts.

Assignee: nobody → gsuntop
Severity: normal → enhancement
Iteration: --- → 67.1 - Jan 28 - Feb 10
Priority: -- → P1

[Tracking Requested - why for this release]: uplift will be requested for Pocket + New Tab experiments

Summary: Refine text rendering for components → Removing truncation + character counts
Keywords: github-merged
Blocks: 1525452
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Blocks: 1525422
Attachment #9042638 - Attachment description: Bug 1524321 - Remove character counts and truncation for ddiscovery stream → Bug 1524321 - Remove character counts and truncation for discovery stream

Comment on attachment 9040508 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4751

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1524321

User impact if declined

Text may truncate in unexpected ways, showing ellipses in some instances.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

  1. Open about:config
  2. Change browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
  3. Open a new tab
  4. Confirm that no ellipses are visible in text

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Function for truncation is being removed and all references are also being removed. Code is being simplified.

String changes made/needed

Attachment #9040508 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Whiteboard: [qa-triaged]

Hello,

I have reproduced this issue with 67.0a1(BuildID:20190131214909)on Windows 10x64

Ellipses are no longer present latest FF Nightly (BuildID:20190212095015)

Disregard the NI Request.

Flags: needinfo?(gsuntop)
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Flags: needinfo?(gsuntop)
Comment on attachment 9040508 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4751

Tweak to Activity Stream, part of planned uplifts for 66 experiments. 
This should land for beta 8.
Attachment #9040508 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Aryx, can you please uplift this?

Flags: needinfo?(gsuntop)
Flags: needinfo?(gsuntop) → needinfo?(aryx.bugmail)

The uplift request should have been on a phabricator attachment instead of the github PR. I'm not sure which phabricator attachment is wanted and which is obsolete, but both don't have a r+.

No Phabricator patch has an r+ - blocked by this.

Flags: needinfo?(aryx.bugmail) → needinfo?(gsuntop)
Attachment #9043352 - Attachment is obsolete: true

Kate and/or Ed will be picking up the Phabricator patch.

Flags: needinfo?(gsuntop)

The patch is updated and reviewed

Ah, I wondered why I couldn't see it in Phabricator. Thanks!

I just updated the patch again, this is actually also dependent on Bug 1520258.

I have re-verified this issue again in the 66.0b8(BuildID: 20190214102000 Build from taskcluster) on Win 10x64. Ubuntu 16.04 and macOS 10.12. Confirming this as verified fixed.

QA Whiteboard: [qa-triaged]
Whiteboard: [qa-triaged]
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.