Status

()

defect
P1
normal
VERIFIED FIXED
4 months ago
3 months ago

People

(Reporter: gsuntop, Assigned: gsuntop)

Tracking

({github-merged})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66+ fixed, firefox67 verified)

Details

Attachments

(5 attachments)

Assignee

Description

4 months ago
Posted image comp

Add a new Message component with the following schema:

  • Header (text)
  • Header Icon (text – URL)
  • Subheader (text)
  • Link Text (text)
  • Link URL (text – URL)
Assignee

Updated

4 months ago
Assignee: nobody → gsuntop
Assignee

Comment 1

4 months ago

Blocked by discussion w. legal. Schema may change...

Assignee

Updated

4 months ago
Summary: Add Header component → Add Message component
Assignee

Updated

4 months ago
Assignee: gsuntop → mathijs

Updated

4 months ago
Assignee: mathijs → gsuntop
Status: NEW → ASSIGNED

Comment 2

4 months ago

The Message component is part of dev-test-all. Let me know when it's ready to be added to the basic layout.

Severity: normal → enhancement
Iteration: --- → 67.1 - Jan 28 - Feb 10
Priority: -- → P1

[Tracking Requested - why for this release]: uplift will be requested for Pocket NT experiments in 66

Keywords: github-merged

Updated

4 months ago
Blocks: 1525452

Comment 5

3 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Assignee

Comment 8

3 months ago
Posted image comp
Assignee

Comment 9

3 months ago

Comment on attachment 9042224 [details]
Bug 1524322 - Add Message component to Discovery Stream

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1524322

User impact if declined

This component is used in the upcoming Pocket New Tab experience and will be used to deliver legal disclaimers to users.

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

Yes

If yes, steps to reproduce

  1. Open about:config
  2. Change browser.newtabpage.activity-stream.discoverystream.config to {"enabled":true,"show_spocs":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-all"}
  3. Open a new tab
  4. Confirm that there's a component matching this comp: https://bug1524322.bmoattachments.org/attachment.cgi?id=9042229

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

This component is self-contained and has no external dependencies.

String changes made/needed

Attachment #9042224 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Whiteboard: [qa-triaged]

I have verified this issue with the latest Firefox Nightly (67.0a1 - Build ID: 20190211092917) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3 and I can confirm that the "Recommended by Pocket" component is matching the provided mock-ups.

Status: RESOLVED → VERIFIED
Flags: qe-verify+

Comment on attachment 9042224 [details]
Bug 1524322 - Add Message component to Discovery Stream

Verified in nightly, ok for uplift for beta 7 or 8.

Attachment #9042224 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]
Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.