Closed Bug 1524325 Opened 5 years ago Closed 5 years ago

needsRestart is stopping the onInstalling event, maybe others

Categories

(Toolkit :: Add-ons Manager, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mixedpuppy, Assigned: aswan)

Details

Attachments

(1 file)

amWebAPI.js, line 258: TypeError: Missing required 'needsRestart' member of AddonEventInit.

A simple fix is to default needsRestart to false here:

https://searchfox.org/mozilla-central/rev/6e3cc153566f5f288ae768a2172385b8436d61dd/toolkit/mozapps/extensions/addonManager.js#155

We don't have anything left that requires a restart, lets just rip needsRestart out of the webidl for mozAddonManager/AddonEvent, etc.

Priority: -- → P2

We haven't supported addons that require restarts in some time
and a bunch of the underlying support for this flag is already gone
from the addons manager. The mozAddonManager api is one of the
last vestiges, this patch rips it out.

Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c7a0af90beb9
Remove AddonEvent.needsRestart r=bzbarsky,kmag
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee: nobody → aswan
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: