1524352 - [jittest] Improve ADBProcessError messages in run_test_remote

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Bob Clary [:bc] (inactive)]

Bug 1518628 and Bug 1518719 are examples of Android jittest failures which are hard for Sheriffs to classify due to the limited and somewhat misleading error message which is produced in run_test_remote.

In one instance we have the device serial number in the "not found" message and test failure line which causes Treeherder to fail to provide suggested bugs in the Failure Summary.

In the other, we have an "error: closed" message which is not helpful.

This can be improved.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-1524352-adbprocess-error-handling.patch

Try run with 100 iterations:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ad2e7b6fcb47812e302e0763e118f81b3b72b20

Things are complicated by the fact that the js-style shell tests depend on non-zero exit codes.

After several iterations where I attempted to prevent the log parser from inadvertently marking the ADBProcessError text from being marked as an error, I realized that check_output had the logic to determine if a non-zero return code from the shell process was an error or not. One thing led to another and I believe that we shouldn't output the exception output at all in the except: block but should instead defer to the remainder of the output logic to determine if the exception really was an error.

Comment 2

[Geoff Brown [:gbrown]]

Comment on attachment 9041073 [details] [diff] [review]
bug-1524352-adbprocess-error-handling.patch

Review of attachment 9041073 [details] [diff] [review]:
-----------------------------------------------------------------

That seems right to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a8810509cdb
[jittest] Improve ADBProcessError messages in run_test_remote, r=gbrown.

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8a8810509cdb