1524353 - Temperature graph of Google weather forecast not confined to box

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Viktor Jägersküpper]

Attachment: Google weather forecast temperature graph

The temperature graph shown by the Google weather forecast is not confined to the box which is shown on that page. The rain and the wind forecasts are not affected. I see this on Linux with "gfx.webrender.all" set to "true".

This is a regression in the latest Nightly build 20190131093752 and likely the same issue as bug 1524303.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Indeed. I've backed out the regressing changeset for now.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1524353 - Add a reftest to prevent regression. r?jrmuizel

The Google weather search result widget has an SVG inside a transform,
inside a scrollframe. The patch in bug 1523776 broke the clipping in
that the SVG elements would not get clipped by the scrollframe. This
reftest exercises that scenario.

Depends on D18272

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd1b2fd6e27
Add a reftest to prevent regression. r=jrmuizel

Comment 4

[Cosmin Sabou [:CosminS]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=linux%2Cx64%2Cquantumrender%2Copt%2Creftests%2Cwith%2Ce10s%2Ctest-linux64-qr%2Fopt-reftest-e10s-5%2Cr-e10s%28r5%29&fromchange=f515f2a68f6fb0834dfe2b88912d4ba3a357b86b&tochange=8962ce22a02ad984121871bd22ff803a3fb03a7d&selectedJob=225319859&group_state=expanded

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=225319859&repo=mozilla-inbound&lineNumber=7089

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/8962ce22a02ad984121871bd22ff803a3fb03a7d

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Needs (14,44) fuzzing with WR. It was passing for me locally :/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a869fd95d89
Add a reftest to prevent regression. r=jrmuizel

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4a869fd95d89

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Would like to uplift this, a=test-only

Comment 9

[Liz Henry (:lizzard)]

Sure, please go ahead.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-beta/rev/328a24b8e49e2313f134436e7dbe29df3680ccb3