Closed
Bug 1524361
Opened 6 years ago
Closed 6 years ago
35,600 instances of "NS_ENSURE_TRUE(domReturn) failed" emitted from dom/base/nsGlobalWindowOuter.cpp during linux64 debug testing
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: erahm, Assigned: nika)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
35618 WARNING: NS_ENSURE_TRUE(domReturn) failed: file dom/base/nsGlobalWindowOuter.cpp, line 7207
This warning [1] shows up in the following test suites:
1730 - test-linux64/debug-crashtest-sw-e10s C
1730 - test-linux64/debug-crashtest-e10s C
1357 - test-linux64/debug-web-platform-tests-sw-e10s-10 wpt10
1357 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
1209 - test-linux64/debug-web-platform-tests-sw-e10s-4 wpt4
1209 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
1150 - test-linux64/debug-web-platform-tests-sw-e10s-18 wpt18
1150 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
1104 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
1104 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
1067 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
1067 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
1058 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
1058 - test-linux64/debug-web-platform-tests-sw-e10s-11 wpt11
971 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
971 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
889 - test-linux64/debug-web-platform-tests-sw-e10s-8 wpt8
889 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
871 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
871 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
853 - test-linux64/debug-web-platform-tests-sw-e10s-7 wpt7
853 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
805 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
805 - test-linux64/debug-web-platform-tests-sw-e10s-3 wpt3
759 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
757 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
748 - test-linux64/debug-web-platform-tests-sw-e10s-13 wpt13
748 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
707 - test-linux64/debug-web-platform-tests-sw-e10s-17 wpt17
707 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
689 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
689 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
655 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
655 - test-linux64/debug-web-platform-tests-sw-e10s-1 wpt1
616 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
615 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
440 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
440 - test-linux64/debug-web-platform-tests-sw-e10s-6 wpt6
73 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
73 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-12 bc12
14 - test-linux64/debug-mochitest-chrome-sw-1 c1
14 - test-linux64/debug-mochitest-chrome-1 c1
12 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-8 bc8
12 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
10 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
10 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
5 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
5 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
5 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
4 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
4 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
3 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
2 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
1 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
1 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
1 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-3 dt3
1 - test-linux64/debug-mochitest-e10s-2 2
1 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
1 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
1 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
1 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
1 - test-linux64/debug-mochitest-sw-e10s-5 5
1 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
1 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
1 - test-linux64/debug-mochitest-plain-headless-sw-e10s-2 h2
1 - test-linux64/debug-mochitest-sw-e10s-2 2
1 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
1 - test-linux64/debug-mochitest-e10s-5 5
1 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
1 - test-linux64/debug-mochitest-plain-headless-sw-e10s-5 h5
1 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
1 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
It shows up in 15903 tests. A few of the most prevalent:
3456 - [e10s] file:///builds/worker/workspace/build/tests/reftest/tests/dom/base/crashtests/1419902.html
144 - [e10s] dom/tests/browser/browser_noopener.js
28 - dom/base/test/test_anchor_target_blank_referrer.html
24 - [e10s] browser/base/content/test/referrer/browser_referrer_click_pinned_tab.js
20 - [e10s] dom/html/test/browser_targetBlankNoOpener.js
18 - [e10s] /html/semantics/links/links-created-by-a-and-area-elements/target_blank_implicit_noopener.tentative.html
10 - [e10s] /html/browsers/the-window-object/window-open-noopener.html?indexed
6 - [e10s] /html/browsers/windows/noreferrer-window-name.html
6 - [e10s] /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html
4 - [e10s] /html/syntax/parsing/html5lib_tests12.html?run_type=NNNNNN
[1] https://hg.mozilla.org/mozilla-central/annotate/9ee54a21a22a/dom/base/nsGlobalWindowOuter.cpp#l7207
Assignee | ||
Comment 2•6 years ago
|
||
Mmm - yeah we shouldn't have that warning there. Having a null return value is to be expected if noopener
or similar is used.
Flags: needinfo?(nika)
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → nika
Updated•6 years ago
|
Priority: -- → P2
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00e932660609
Remove unnecessary warning from OpenInternal return codepath, r=smaug
Comment 5•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•