Closed Bug 1524362 Opened 5 years ago Closed 5 years ago

34,800 instances of "NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111" emitted from netwerk/protocol/res/SubstitutingProtocolHandler.cpp during linux64 debug testing

Categories

(Core :: Networking, defect, P2)

Product:
Core
Component:
Networking
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: erahm, Assigned: f20160385)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

bug 1524362 - 34,800 instances of "NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111" emitted from netwerk/protocol/res/SubstitutingProtocolHandler.cpp during linux64 debug testing
47 bytes, text/x-phabricator-request
Details | Review

34761 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 319

This warning [1] shows up in the following test suites:

   696 - test-linux64/debug-web-platform-tests-wdspec-e10s-1 Wd1
   696 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-1 Wd1
   584 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-2 Wd2
   584 - test-linux64/debug-web-platform-tests-wdspec-e10s-2 Wd2
   561 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
   561 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
   561 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
   561 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
   391 - test-linux64/debug-mochitest-sw-e10s-15 15
   390 - test-linux64/debug-test-verify-e10s-1 TV1
   385 - test-linux64/debug-mochitest-e10s-15 15
   377 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
   377 - test-linux64/debug-mochitest-plain-headless-sw-e10s-15 h15
   304 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
   304 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
   300 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
   300 - test-linux64/debug-web-platform-tests-sw-e10s-1 wpt1
   296 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
   296 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
   290 - test-linux64/debug-marionette-headless-e10s MnH
   290 - test-linux64/debug-marionette-e10s Mn
   288 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
   288 - test-linux64/debug-web-platform-tests-sw-e10s-10 wpt10
   284 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
   280 - test-linux64/debug-web-platform-tests-sw-e10s-3 wpt3
   280 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
   280 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
   280 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
   280 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
   276 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
   276 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
   276 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
   276 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
   270 - test-linux64/debug-reftest-e10s-6 R6
   270 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
   270 - test-linux64/debug-reftest-no-accel-sw-e10s-6 Ru6
   270 - test-linux64/debug-reftest-sw-e10s-6 R6
   265 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
   265 - test-linux64/debug-reftest-no-accel-sw-e10s-3 Ru3
   265 - test-linux64/debug-reftest-sw-e10s-1 R1
   265 - test-linux64/debug-reftest-no-accel-sw-e10s-4 Ru4
   265 - test-linux64/debug-reftest-no-accel-sw-e10s-1 Ru1
   265 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
   265 - test-linux64/debug-reftest-sw-e10s-3 R3
   265 - test-linux64/debug-reftest-e10s-3 R3
   265 - test-linux64/debug-reftest-sw-e10s-4 R4
   265 - test-linux64/debug-reftest-e10s-4 R4
   265 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
   265 - test-linux64/debug-reftest-e10s-1 R1
   260 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
   260 - test-linux64/debug-web-platform-tests-sw-e10s-18 wpt18
   260 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
   260 - test-linux64/debug-reftest-e10s-2 R2
   260 - test-linux64/debug-web-platform-tests-sw-e10s-4 wpt4
   260 - test-linux64/debug-reftest-no-accel-sw-e10s-2 Ru2
   260 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
   260 - test-linux64/debug-reftest-sw-e10s-2 R2
   256 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
   256 - test-linux64/debug-web-platform-tests-sw-e10s-11 wpt11
   255 - test-linux64/debug-reftest-e10s-7 R7
   255 - test-linux64/debug-reftest-sw-e10s-7 R7
   255 - test-linux64/debug-reftest-no-accel-sw-e10s-7 Ru7
   255 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
   252 - test-linux64/debug-web-platform-tests-sw-e10s-7 wpt7
   252 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
   252 - test-linux64/debug-web-platform-tests-sw-e10s-6 wpt6
   252 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
   244 - test-linux64/debug-web-platform-tests-sw-e10s-17 wpt17
   244 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
   240 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
   240 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
   240 - test-linux64/debug-mochitest-chrome-2 c2
   240 - test-linux64/debug-mochitest-chrome-sw-2 c2
   236 - test-linux64/debug-web-platform-tests-sw-e10s-13 wpt13
   236 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
   230 - test-linux64/debug-reftest-e10s-5 R5
   230 - test-linux64/debug-reftest-sw-e10s-5 R5
   230 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
   230 - test-linux64/debug-reftest-no-accel-sw-e10s-5 Ru5
   219 - test-linux64/debug-mochitest-chrome-sw-3 c3
   219 - test-linux64/debug-mochitest-chrome-3 c3
   216 - test-linux64/debug-mochitest-chrome-sw-1 c1
   216 - test-linux64/debug-mochitest-chrome-1 c1
   212 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
   212 - test-linux64/debug-web-platform-tests-sw-e10s-8 wpt8
   200 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
   200 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-1 Wr1
   192 - test-linux64/debug-mochitest-clipboard-sw-e10s cl
   192 - test-linux64/debug-mochitest-clipboard-e10s cl
   173 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
   164 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-3 Wr3
   164 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
   164 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-4 Wr4
   164 - test-linux64/debug-web-platform-tests-reftests-e10s-5 Wr5
   164 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-6 Wr6
   164 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-5 Wr5
   164 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
   164 - test-linux64/debug-web-platform-tests-reftests-e10s-6 Wr6
   164 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
   156 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-2 Wr2
   156 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
   125 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
   121 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
   115 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
   111 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
    99 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
    97 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
    95 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
    95 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-5 bc5
    94 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-1 bc1
    94 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
    93 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
    93 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-8 bc8
    91 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
    90 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-4 bc4
    90 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
    87 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-10 bc10
    85 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
    84 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
    84 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
    84 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
    79 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-6 dt6
    78 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
    72 - test-linux64/debug-mochitest-e10s-8 8
    72 - test-linux64/debug-mochitest-plain-headless-sw-e10s-8 h8
    69 - test-linux64/debug-mochitest-sw-e10s-1 1
    69 - test-linux64/debug-mochitest-plain-headless-e10s-1 h1
    69 - test-linux64/debug-mochitest-e10s-1 1
    68 - test-linux64/debug-mochitest-plain-headless-e10s-11 h11
    68 - test-linux64/debug-mochitest-plain-headless-sw-e10s-11 h11
    68 - test-linux64/debug-mochitest-sw-e10s-11 11
    68 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
    68 - test-linux64/debug-mochitest-sw-e10s-9 9
    67 - test-linux64/debug-mochitest-sw-e10s-5 5
    67 - test-linux64/debug-mochitest-e10s-5 5
    67 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
    66 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
    66 - test-linux64/debug-mochitest-sw-e10s-8 8
    64 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
    63 - test-linux64/debug-mochitest-plain-headless-sw-e10s-1 h1
    62 - test-linux64/debug-mochitest-e10s-11 11
    62 - test-linux64/debug-mochitest-e10s-9 9
    62 - test-linux64/debug-mochitest-plain-headless-sw-e10s-9 h9
    61 - test-linux64/debug-mochitest-plain-headless-sw-e10s-5 h5
    61 - test-linux64/debug-mochitest-e10s-3 3
    61 - test-linux64/debug-mochitest-e10s-10 10
    61 - test-linux64/debug-mochitest-plain-headless-e10s-7 h7
    61 - test-linux64/debug-mochitest-plain-headless-sw-e10s-6 h6
    61 - test-linux64/debug-mochitest-sw-e10s-7 7
    61 - test-linux64/debug-mochitest-e10s-14 14
    61 - test-linux64/debug-mochitest-sw-e10s-3 3
    61 - test-linux64/debug-mochitest-plain-headless-e10s-3 h3
    61 - test-linux64/debug-mochitest-e10s-7 7
    60 - test-linux64/debug-mochitest-plain-headless-sw-e10s-4 h4
    58 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-8 dt8
    58 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
    55 - test-linux64/debug-mochitest-sw-e10s-10 10
    55 - test-linux64/debug-mochitest-e10s-6 6
    55 - test-linux64/debug-mochitest-sw-e10s-14 14
    55 - test-linux64/debug-mochitest-plain-headless-sw-e10s-10 h10
    55 - test-linux64/debug-mochitest-sw-e10s-6 6
    55 - test-linux64/debug-mochitest-plain-headless-e10s-6 h6
    55 - test-linux64/debug-mochitest-plain-headless-sw-e10s-3 h3
    55 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
    55 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
    55 - test-linux64/debug-mochitest-plain-headless-sw-e10s-14 h14
    55 - test-linux64/debug-mochitest-plain-headless-sw-e10s-7 h7
    54 - test-linux64/debug-mochitest-plain-headless-sw-e10s-13 h13
    54 - test-linux64/debug-mochitest-sw-e10s-13 13
    54 - test-linux64/debug-mochitest-sw-e10s-4 4
    54 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
    54 - test-linux64/debug-mochitest-e10s-16 16
    54 - test-linux64/debug-mochitest-e10s-12 12
    54 - test-linux64/debug-mochitest-e10s-4 4
    54 - test-linux64/debug-mochitest-plain-headless-e10s-13 h13
    48 - test-linux64/debug-mochitest-gpu-sw-e10s gpu
    48 - test-linux64/debug-mochitest-plain-headless-e10s-16 h16
    48 - test-linux64/debug-mochitest-sw-e10s-12 12
    48 - test-linux64/debug-mochitest-sw-e10s-16 16
    48 - test-linux64/debug-mochitest-plain-headless-sw-e10s-16 h16
    48 - test-linux64/debug-mochitest-plain-headless-sw-e10s-12 h12
    48 - test-linux64/debug-mochitest-e10s-13 13
    48 - test-linux64/debug-mochitest-plain-headless-e10s-12 h12
    48 - test-linux64/debug-mochitest-gpu-e10s gpu
    42 - test-linux64/debug-mochitest-plain-headless-sw-e10s-2 h2
    37 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
    36 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
    36 - test-linux64/debug-mochitest-media-sw-e10s-3 mda3
    36 - test-linux64/debug-mochitest-e10s-2 2
    36 - test-linux64/debug-mochitest-media-e10s-3 mda3
    36 - test-linux64/debug-mochitest-sw-e10s-2 2
    32 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-3 dt3
    32 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
    30 - test-linux64/debug-mochitest-webgl1-core-sw-e10s gl1c
    30 - test-linux64/debug-mochitest-webgl1-core-e10s gl1c
    30 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-4 dt4
    25 - test-linux64/debug-telemetry-tests-client-e10s c
    25 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
    25 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-7 dt7
    24 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-1 dt1
    24 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
    24 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
    24 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-2 dt2
    19 - test-linux64/debug-mochitest-media-sw-e10s-1 mda1
    19 - test-linux64/debug-mochitest-media-e10s-1 mda1
    18 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-5 dt5
    18 - test-linux64/debug-mochitest-media-e10s-2 mda2
    18 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
    18 - test-linux64/debug-mochitest-media-sw-e10s-2 mda2
    10 - test-linux64/debug-reftest-e10s-8 R8
    10 - test-linux64/debug-reftest-no-accel-sw-e10s-8 Ru8
    10 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
    10 - test-linux64/debug-reftest-sw-e10s-8 R8
     6 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-9 dt9
     6 - test-linux64/debug-mochitest-webgl1-ext-sw-e10s gl1e
     6 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-12 dt12
     6 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-12 bc12
     6 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
     6 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11
     6 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
     6 - test-linux64/debug-mochitest-webgl1-ext-e10s gl1e
     6 - test-linux64/debug-mochitest-a11y a11y
     6 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-14 bc14
     6 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-10 dt10
     6 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
     6 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
     6 - test-linux64/debug-mochitest-a11y-sw a11y
     6 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
     6 - test-linux64/debug-crashtest-sw-e10s C
     6 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
     6 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
     6 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-11 dt11
     6 - test-linux64/debug-crashtest-e10s C
     4 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US

It shows up in 2693 tests. A few of the most prevalent:

  6446 - [e10s] Shutdown
  1116 -        Shutdown
   144 -        browser/components/shell/test/test_headless_screenshot.html
    56 - [e10s] js/xpconnect/tests/marionette/test_loader_global_sharing.py TestLoaderGlobalSharing.test_global_sharing_settings
    52 - [e10s] browser/components/extensions/test/browser/browser_ext_browserAction_theme_icons.js
    52 - [e10s] browser/components/extensions/test/browser/test-oop-extensions/browser_ext_browserAction_theme_icons.js
    48 - [e10s] /webdriver/tests/get_page_source/user_prompts.py
    48 - [e10s] /webdriver/tests/find_elements_from_element/user_prompts.py
    48 - [e10s] /webdriver/tests/find_element_from_element/user_prompts.py
    48 - [e10s] /webdriver/tests/close_window/user_prompts.py

[1] https://hg.mozilla.org/mozilla-central/annotate/9ee54a21a22a/netwerk/protocol/res/SubstitutingProtocolHandler.cpp#l319

  • we should figure out which of the calls in [1] fails (add ns_ensure on each)
  • then deal with it based on whether the failure is a bug or not (probably not :))
  • replace this NS_ENSURE with a plain return.

[1] https://searchfox.org/mozilla-central/rev/e00ea598e52bbb35f8c45abf9c2eade17962bb5e/netwerk/protocol/res/SubstitutingProtocolHandler.cpp#382

Priority: -- → P2
Whiteboard: [necko-triaged]

(In reply to Honza Bambas (:mayhemer) from comment #1)

  • we should figure out which of the calls in [1] fails (add ns_ensure on each)

It's all stuff like this:

   211 WARNING: Failed to get substitution for resource://modules/PlacesUtils.jsm: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 429
   171 WARNING: Failed to get substitution for moz-extension://db6c8705-90bb-4fe0-8d3e-6f6e6ac53833/: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 429

So failing the substitution step on resource:// and moz-extension::// urls.

Which implies that nsResProtocolHandler::GetSubstitutionInternal is returning NS_ERROR_NOT_AVAILABLE. It seems like this might be a bug where we're bailing early if there's no substitution (unless that's actually required).

Honza, what do you think? Should we just remove the NS_ENSURE or is this an actual bug?

Flags: needinfo?(honzab.moz)

(In reply to Eric Rahm [:erahm] (ni? for phab reviews) from comment #2)

Which implies that nsResProtocolHandler::GetSubstitutionInternal is [returning NS_ERROR_NOT_AVAILABLE]

is it confirmed? do we know what exact spot errors here?

It seems like this might be a bug where we're bailing early if there's no substitution (unless that's actually required).

No idea if this is a bug or not until that is answered.

Flags: needinfo?(honzab.moz)

(In reply to Honza Bambas (:mayhemer) from comment #3)

(In reply to Eric Rahm [:erahm] (ni? for phab reviews) from comment #2)

Which implies that nsResProtocolHandler::GetSubstitutionInternal is [returning NS_ERROR_NOT_AVAILABLE]

is it confirmed? do we know what exact spot errors here?

I deduced that from code inspection, I can do a push if you really want but at this point this might be better served by a necko person taking over the investigation.

It seems like this might be a bug where we're bailing early if there's no substitution (unless that's actually required).

No idea if this is a bug or not until that is answered.

You can still weigh in on if that is desired behavior. If it's desired we can just remove the warning.

$grep -B1 'WARNING: Failed to get substitution for' try-0d2cd9ecdff2-linux64/*.log | less
try-0d2cd9ecdff2-linux64/debug-mochitest-a11y_a11y.log-WARNING: HONZA IT REALLY IS GETSUBSTITUTIONINTERNAL FAILING WITH NS_ERROR_NOT_AVAILABLE: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 350
try-0d2cd9ecdff2-linux64/debug-mochitest-a11y_a11y.log:WARNING: Failed to get substitution for moz-extension://d60b9239-478d-44cf-813a-a26fb8b98a74/: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 434
--
try-0d2cd9ecdff2-linux64/debug-mochitest-a11y_a11y.log-WARNING: HONZA IT REALLY IS GETSUBSTITUTIONINTERNAL FAILING WITH NS_ERROR_NOT_AVAILABLE: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 350
try-0d2cd9ecdff2-linux64/debug-mochitest-a11y_a11y.log:WARNING: Failed to get substitution for moz-extension://99280643-1e50-4a40-b8c9-61aefa0b5218/: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 434
--
try-0d2cd9ecdff2-linux64/debug-mochitest-a11y_a11y.log-WARNING: HONZA IT REALLY IS GETSUBSTITUTIONINTERNAL FAILING WITH NS_ERROR_NOT_AVAILABLE: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 350
try-0d2cd9ecdff2-linux64/debug-mochitest-a11y_a11y.log:WARNING: Failed to get substitution for moz-extension://4c2e8c5c-463b-43f8-8918-605fc810f859/: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 434
--
try-0d2cd9ecdff2-linux64/debug-mochitest-a11y_a11y.log-WARNING: HONZA IT REALLY IS GETSUBSTITUTIONINTERNAL FAILING WITH NS_ERROR_NOT_AVAILABLE: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 350
try-0d2cd9ecdff2-linux64/debug-mochitest-a11y_a11y.log:WARNING: Failed to get substitution for moz-extension://59e538fa-cfc6-433a-be95-639171e0645a/: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 434
--
try-0d2cd9ecdff2-linux64/debug-mochitest-a11y_a11y.log-WARNING: HONZA IT REALLY IS GETSUBSTITUTIONINTERNAL FAILING WITH NS_ERROR_NOT_AVAILABLE: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 350
try-0d2cd9ecdff2-linux64/debug-mochitest-a11y_a11y.log:WARNING: Failed to get substitution for moz-extension://c4a2d92d-9513-44d6-ae3c-8dbb36794642/: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 434
--

So yes it is the get substitution call. Full report when adding that addtional warning:

113668 WARNING: HONZA IT REALLY IS GETSUBSTITUTIONINTERNAL FAILING WITH NS_ERROR_NOT_AVAILABLE: file netwerk/protocol/res/SubstitutingProtocolHandler.cpp, line 350

This warning [1] shows up in the following test suites:

  7656 - test-linux64/debug-web-platform-tests-wdspec-e10s-1 Wd1
  4818 - test-linux64/debug-web-platform-tests-wdspec-e10s-2 Wd2
  2542 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
  2475 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
  2409 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
  2409 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
  2376 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
  2343 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
  2310 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
  2277 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
  2277 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
  2178 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
  2145 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
  2112 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
  2079 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
  2050 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
  2050 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
  2046 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
  1980 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
  1980 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
  1836 - test-linux64/debug-reftest-e10s-7 R7
  1836 - test-linux64/debug-reftest-e10s-5 R5
  1836 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
  1836 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
  1782 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
  1768 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
  1768 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
  1768 - test-linux64/debug-reftest-e10s-3 R3
  1768 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
  1768 - test-linux64/debug-reftest-e10s-1 R1
  1768 - test-linux64/debug-reftest-e10s-2 R2
  1734 - test-linux64/debug-reftest-e10s-6 R6
  1734 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
  1650 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
  1598 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
  1598 - test-linux64/debug-reftest-e10s-4 R4
  1434 - test-linux64/debug-mochitest-e10s-15 15
  1434 - test-linux64/debug-mochitest-chrome-1 c1
  1427 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
  1402 - test-linux64/debug-mochitest-chrome-2 c2
  1386 - test-linux64/debug-web-platform-tests-reftests-e10s-5 Wr5
  1386 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
  1386 - test-linux64/debug-web-platform-tests-reftests-e10s-6 Wr6
  1353 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
  1287 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
  1213 - test-linux64/debug-mochitest-chrome-3 c3
  1124 - test-linux64/debug-mochitest-clipboard-e10s cl
   924 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
   577 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
   567 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
   536 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
   534 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
   533 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
   525 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
   515 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
   498 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
   446 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
   420 - test-linux64/debug-mochitest-e10s-8 8
   409 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
   385 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
   364 - test-linux64/debug-mochitest-plain-headless-e10s-1 h1
   364 - test-linux64/debug-mochitest-e10s-1 1
   358 - test-linux64/debug-mochitest-e10s-5 5
   358 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
   331 - test-linux64/debug-mochitest-plain-headless-e10s-11 h11
   331 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
   323 - test-linux64/debug-mochitest-e10s-7 7
   323 - test-linux64/debug-mochitest-e10s-3 3
   323 - test-linux64/debug-mochitest-e10s-14 14
   323 - test-linux64/debug-mochitest-plain-headless-e10s-3 h3
   323 - test-linux64/debug-mochitest-e10s-10 10
   323 - test-linux64/debug-mochitest-plain-headless-e10s-7 h7
   315 - test-linux64/debug-mochitest-e10s-16 16
   315 - test-linux64/debug-mochitest-e10s-12 12
   315 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
   315 - test-linux64/debug-mochitest-e10s-4 4
   315 - test-linux64/debug-mochitest-plain-headless-e10s-13 h13
   296 - test-linux64/debug-mochitest-e10s-11 11
   296 - test-linux64/debug-mochitest-e10s-9 9
   288 - test-linux64/debug-mochitest-e10s-6 6
   288 - test-linux64/debug-mochitest-plain-headless-e10s-6 h6
   288 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
   288 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
   280 - test-linux64/debug-mochitest-plain-headless-e10s-16 h16
   280 - test-linux64/debug-mochitest-e10s-13 13
   280 - test-linux64/debug-mochitest-gpu-e10s gpu
   280 - test-linux64/debug-mochitest-plain-headless-e10s-12 h12
   274 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
   245 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
   213 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
   210 - test-linux64/debug-mochitest-e10s-2 2
   210 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
   210 - test-linux64/debug-mochitest-media-e10s-3 mda3
   185 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
   175 - test-linux64/debug-mochitest-webgl1-core-e10s gl1c
   175 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
   144 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
   143 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
   106 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
   105 - test-linux64/debug-mochitest-media-e10s-2 mda2
    78 - test-linux64/debug-mochitest-media-e10s-1 mda1
    68 - test-linux64/debug-reftest-e10s-8 R8
    68 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
    35 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
    35 - test-linux64/debug-mochitest-webgl1-ext-e10s gl1e
    35 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
    35 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
    35 - test-linux64/debug-mochitest-a11y a11y
    35 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
    35 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
    35 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
    35 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11

It shows up in 2592 tests. A few of the most prevalent:

 16803 - [e10s] Shutdown
  3255 -        Shutdown
   891 - [e10s] /webdriver/tests/new_session/create_alwaysMatch.py
   891 - [e10s] /webdriver/tests/new_session/create_firstMatch.py
   594 -        browser/components/shell/test/test_headless_screenshot.html
   198 - [e10s] /webdriver/tests/get_page_source/user_prompts.py
   198 - [e10s] /webdriver/tests/find_elements_from_element/user_prompts.py
   198 - [e10s] /webdriver/tests/find_element_from_element/user_prompts.py
   198 - [e10s] /webdriver/tests/element_click/user_prompts.py
   198 - [e10s] /webdriver/tests/find_elements/user_prompts.py

[1] https://hg.mozilla.org/try/annotate/0d2cd9ecdff2/netwerk/protocol/res/SubstitutingProtocolHandler.cpp#l350

Thanks for doing this! There is one more level of nesting, I can see it now!

Hmm... in the ideal world it would be great to have a new error code for not finding the substitution, and handle it with |if (rv == NS_ERROR_SUBSTITUTION_URI_NOT_FOUND) return rv;| and do NS_ENSURE. But that is IMHO an overkill. So let's just remove the NS_ENSURE on line 319.

Thanks for confirming this!

Hi. I want to work on this bug. Please tell me how do I proceed.

Flags: needinfo?(erahm)

Thanks for the patch Khyati, I'll get this landed.

Flags: needinfo?(erahm)
Pushed by erahm@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/643d46a6c490
34,800 instances of "NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111" emitted from netwerk/protocol/res/SubstitutingProtocolHandler.cpp during linux64 debug testing r=valentin

Could you make it assigned to me? Thanks.

Flags: needinfo?(erahm)

https://hg.mozilla.org/mozilla-central/rev/643d46a6c490

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → f20160385
Flags: needinfo?(erahm)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: