1524366 - PROCESS-CRASH | Main app process exited normally | application crashed [@ mozilla::ipc::MessageChannel::Close()]

Status: RESOLVED DUPLICATE of bug 1520672

(Toolkit :: Application Update, defect, P5)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: rstrong [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=225277025&repo=try

https://queue.taskcluster.net/v1/task/JnVYyHTgR0C3JJDMHWIr7A/runs/0/artifacts/public/logs/live_backing.log

This occurs often when running tests that stage updates with --verify (e.g. TV runs)

Comment 1

[Robert Strong (they/them - no direct email)]

Try run that shows this bug
https://treeherder.mozilla.org/#/jobs?repo=try&revision=436d35b291c809881e0e568913048e268cef4917

By backing out the changes to the staging code path from bug 1272614 this bug disappears
Try run
https://treeherder.mozilla.org/#/jobs?repo=try&revision=14750c605937c038144b260f0ee6a51a01966b0c

Comment 2

[Robert Strong (they/them - no direct email)]

Besides fixing the crash the tests fail half as often

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: Patch rev1

Matt, what do you think about reverting the Linux staging code that was changed in bug 1524366 to fix this crash [@ mozilla::ipc::MessageChannel::Close()]

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 9040511 [details] [diff] [review]
Patch rev1

Review of attachment 9040511 [details] [diff] [review]:
-----------------------------------------------------------------

[assuming you meant bug 1272614]

If I remember correctly that patch was pretty speculative, and I don't remember ever seeing evidence that it really solved the problem, so I'm not very attached to this code. Why do you think that's related to this crash, though?

Comment 5

[Robert Strong (they/them - no direct email)]

From comment #3

Try run that shows this bug
https://treeherder.mozilla.org/#/jobs?repo=try&revision=436d35b291c809881e0e568913048e268cef4917

By backing out the changes to the staging code path from bug 1272614 this bug disappears
Try run
https://treeherder.mozilla.org/#/jobs?repo=try&revision=14750c605937c038144b260f0ee6a51a01966b0c

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fc5715105a2
Revert the Linux staging code changed in bug 1524366 to fix crash [@ mozilla::ipc::MessageChannel::Close()]. r=mhowell

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/2fc5715105a2

Comment 8

[Robert Strong (they/them - no direct email)]

Backed out due to bug 1524496
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2168937e103c506b88a3486e21f0739a673e358

Comment 9

[Intermittent Failures Robot]

11 failures in 2628 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 11

Platform breakdown:

• linux64: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524366&startday=2019-01-28&endday=2019-02-03&tree=all

Comment 10

[Robert Strong (they/them - no direct email)]

This test is disabled on Linux for TV runs and the work for this will happen in bug 1520672 so duping to bug 1520672