1524453 - In Google Docs with braille support enabled, typing anywhere but start of document scrambles text

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect, P1)

Description

[James Teh [:Jamie]]

You do not need to be using a screen reader to test this.

STR:

1. Open a blank Google Docs document.
2. Press control+alt+z to enable screen reader support.
3. Press alt+/ (alt+slash) to search the menus. Type "braille"..
4. Press enter to "Enable braille support".
5. Back in the document, type "testing".
6. Press home to move to the start of the line.
7. Type "testing ".
   Expected: The line should now read "Testing testing"
   Actual: The letters are there, but scrambled.

It looks like the cursor sometimes jumps forward when it shouldn't while typing.

Impact: This makes Google Docs pretty unusable for braille users.

17:03.81 INFO: Last good revision: cda49d66b3ccef746f0f077b80173cf0ae3a2899
17:03.81 INFO: First bad revision: ce0cebad842b1fc3c14b552dccaa59dc9ec8dd09
17:03.82 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=cda49d66b3ccef746f0f077b80173cf0ae3a2899&tochange=ce0cebad842b1fc3c14b552dccaa59dc9ec8dd09

This implies bug 1510081 is the culprit. Disabling dom.keyboardevent.keypress.set_keycode_and_charcode_to_same_value does fix this. So, I guess the Google Docs braille support still assumes our old keyCode/charCode mirroring of keypress events?

I don't fully understand the story/history here, but I do have contacts in Google accessibility. Is there someone I can loop into an email thread?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

So, I guess the Google Docs braille support still assumes our old keyCode/charCode mirroring of keypress events?

Yeah, sounds like so.

Comment 2

[Mike Taylor [:miketaylr]]

Apologies for the delay here. Jamie, can you please make an intro via email? Happy to explain the situation to Google accessibility engineers. Thanks.

Comment 3

[James Teh [:Jamie]]

Intro made.

Comment 4

[Mike Taylor [:miketaylr]]

Hi Jamie, can you test if Google fixed this when you get a moment? Thanks.

Comment 5

[James Teh [:Jamie]]

It looks like they did. I re-enabled dom.keyboardevent.keypress.set_keycode_and_charcode_to_same_value and tested the STR from comment 0. I got the expected results; i.e. no scrambling.

Comment 6

[Mike Taylor [:miketaylr]]

Thanks for testing!