Move the |active| flag from BaselineScript to TypeScript
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(4 files)
Before we discard JIT code we set the |active| flag on BaselineScripts that are on the stack to ensure we don't discard these scripts.
Similarly, the Baseline interpreter won't like the TypeScript/ICScript being pulled from under interpreter frames so we have to move the flag to TypeScript instead.
|
Assignee | |
Comment 1•5 years ago
|
||
Patches for this coming up. I ended up cleaning up some TypeScript design issues that make TypeScript a lot nicer to work with and it will make it easier to merge with ICScript and/or rename to JitScript in the future.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Baseline interpreter frames will have a TypeScript/ICScript we want to keep
around on GC.
The JSScript::typesDontCheckGeneration method will be removed in the next patch.
|
|
Assignee | |
Comment 3•5 years ago
|
||
As we add more fields to TypeScript (= JitScript in the future), the
AutoSweepTypeScript argument to JSScript::types() is becoming annoying.
This patch moves the argument to TypeScript::typeArray() and
TypeScript::inlinedCompilations() because that's the data affected by type
sweeping.
Depends on D18548
|
|
Assignee | |
Comment 4•5 years ago
|
||
This is pretty straight-forward now and it's much nicer to encapsulate this in
TypeScript instead of having these types-related flags in JSScript.
Depends on D18549
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D18550
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fdc01631d226 part 1 - Move active flag from BaselineScript to TypeScript. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/936d2328fb86 part 2 - Move the AutoSweepTypeScript& from JSScript::types() to TypeScript methods that depend on swept data. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/71b541173043 part 3 - Move HasFreezeConstraints and TypesGeneration flags from JSScript to TypeScript. r=tcampbell https://hg.mozilla.org/integration/autoland/rev/cd460d5c95f9 part 4 - Some minor changes to address review feedback. r=tcampbell
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fdc01631d226
https://hg.mozilla.org/mozilla-central/rev/936d2328fb86
https://hg.mozilla.org/mozilla-central/rev/71b541173043
https://hg.mozilla.org/mozilla-central/rev/cd460d5c95f9
Description
•