Do not generate BinKind for sum interface

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: arai, Assigned: arai)

Tracking

(Blocks 1 bug)

Trunk
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 months ago

we have sum interface names in BinKind, but it doesn't appear in the BinAST file.
we should remove them from the definition.

Attachment #9043751 - Attachment description: Bug 1524507 - Remove sum interface and typedef from BinToken.h. Yoric → Bug 1524507 - Remove sum interface and typedef from BinToken.h. r?Yoric

Comment 2

2 months ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/885272c243c8
Remove sum interface and typedef from BinToken.h. r=Yoric

Backed out changeset 885272c243c8 (Bug 1524507) for BinToken related bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=885272c243c87325a339a34caf55f3e5e7e86b66&selectedJob=228344393

Backout link: https://hg.mozilla.org/integration/autoland/rev/a4e958b1a97c302b0760478ef34cd909608c2731

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228344393&repo=autoland&lineNumber=9439

[task 2019-02-14T06:45:15.068Z] TEST-PASS | js/src/jit-test/tests/basic/xml-in-strict.js | Success (code 0, args "") [0.2 s]
[task 2019-02-14T06:45:15.068Z] {"action": "test_start", "jitflags": "", "pid": 30170, "source": "jittests", "test": "basic/xml-in-strict.js", "thread": "main", "time": 1550126714.898088}
[task 2019-02-14T06:45:15.068Z] {"action": "test_end", "extra": {"jitflags": "", "pid": 30170}, "jitflags": "", "message": "Success", "pid": 30170, "source": "jittests", "status": "PASS", "test": "basic/xml-in-strict.js", "thread": "main", "time": 1550126715.068589}
[task 2019-02-14T06:45:15.073Z] TEST-PASS | js/src/jit-test/tests/basic/write-frozen-property.js | Success (code 0, args "") [0.2 s]
[task 2019-02-14T06:45:15.074Z] {"action": "test_start", "jitflags": "", "pid": 30169, "source": "jittests", "test": "basic/write-frozen-property.js", "thread": "main", "time": 1550126714.8903348}
[task 2019-02-14T06:45:15.074Z] {"action": "test_end", "extra": {"jitflags": "", "pid": 30169}, "jitflags": "", "message": "Success", "pid": 30169, "source": "jittests", "status": "PASS", "test": "basic/write-frozen-property.js", "thread": "main", "time": 1550126715.073896}
[task 2019-02-14T06:45:15.113Z] Assertion failure: !ptr, at /builds/worker/workspace/build/src/js/src/frontend/BinToken.cpp:89
[task 2019-02-14T06:45:15.114Z] Exit code: -11
[task 2019-02-14T06:45:15.115Z] FAIL - binast/shorthand.binjs
[task 2019-02-14T06:45:15.115Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/binast/shorthand.binjs | Assertion failure: !ptr, at /builds/worker/workspace/build/src/js/src/frontend/BinToken.cpp:89 (code -11, args "") [0.2 s]
[task 2019-02-14T06:45:15.116Z] {"action": "test_start", "jitflags": "", "pid": 30199, "source": "jittests", "test": "binast/shorthand.binjs", "thread": "main", "time": 1550126714.927227}
[task 2019-02-14T06:45:15.117Z] {"action": "test_end", "extra": {"jitflags": "", "pid": 30199}, "jitflags": "", "message": "Assertion failure: !ptr, at /builds/worker/workspace/build/src/js/src/frontend/BinToken.cpp:89", "pid": 30199, "source": "jittests", "status": "FAIL", "test": "binast/shorthand.binjs", "thread": "main", "time": 1550126715.113814}
[task 2019-02-14T06:45:15.117Z] INFO exit-status : -11
[task 2019-02-14T06:45:15.118Z] INFO timed-out : False
[task 2019-02-14T06:45:15.118Z] INFO stderr 2> Assertion failure: !ptr, at /builds/worker/workspace/build/src/js/src/frontend/BinToken.cpp:89
[task 2019-02-14T06:45:15.153Z] TEST-PASS | js/src/jit-test/tests/binast/shorthand.js | Success (code 0, args "") [0.2 s]
[task 2019-02-14T06:45:15.154Z] {"action": "test_start", "jitflags": "", "pid": 30209, "source": "jittests", "test": "binast/shorthand.js", "thread": "main", "time": 1550126714.967411}
[task 2019-02-14T06:45:15.154Z] {"action": "test_end", "extra": {"jitflags": "", "pid": 30209}, "jitflags": "", "message": "Success", "pid": 30209, "source": "jittests", "status": "PASS", "test": "binast/shorthand.js", "thread": "main", "time": 1550126715.153914}
[task 2019-02-14T06:45:15.200Z] TEST-PASS | js/src/jit-test/tests/cacheir/alloc-dense-elements.js | Success (code 0, args "") [0.2 s]

Flags: needinfo?(arai.unmht)
(Assignee)

Comment 4

2 months ago

the patch was incomplete.
will fix shortly.

Flags: needinfo?(arai.unmht)

Comment 5

2 months ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/7f857fddc903
Remove sum interface and typedef from BinToken.h. r=Yoric

Comment 6

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.