1524553 - Differential messages show diff-associated messages after the wrong line of the patch.

Status: NEW

(Conduit :: Phabricator, enhancement, P3)

Description

[Mike Hommey [:glandium]]

The mail I got for https://phabricator.services.mozilla.com/D18281#468527 said:

> rust.mk:84
> +export AR_$(rust_cc_env_name)=$(AR)
> +ifeq (,$(MOZ_ASAN)$(MOZ_TSAN)$(MOZ_UBSAN)$(CODE_COVERAGE_GCC)$(FUZZING_INTERFACES))
>  export CFLAGS_$(rust_host_cc_env_name)=$(COMPUTED_HOST_CFLAGS)

It might be worthwhile to add a specially-named subst for this and set it in configure so that it's more discoverable.

> rust.mk:91
> +# Because cargo doesn't allow to distinguish builds happening for build
> +# scripts/procedural macros vs. those happening for the rust target,
> +# we can't blindly pass all our flags down for cc-rs to use them, because of the

Relevant cargo issues if you'd like to link them somewhere:
https://github.com/rust-lang/cargo/issues/5754
https://github.com/rust-lang/cargo/issues/5755

Note how the first quote makes it confusing what "this" refers to, while reading it on the web, where it's associated to the ifeq line, it's pretty clear what this is about.