input type="range" rendering issues on macOS
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox65 | --- | wontfix |
firefox66 | --- | wontfix |
firefox67 | --- | fixed |
People
(Reporter: mikokm, Assigned: MatsPalmgren_bugz)
References
Details
(Keywords: regression, testcase)
Attachments
(5 files, 1 obsolete file)
The changes in bug 1317870 and/or bug 1481593 regressed <input type="range"> rendering on macOS: the slider thumb is clipped incorrectly.
If ::-moz-range-thumb is set1, the slider track disappears altogether.
Reporter | ||
Comment 1•5 years ago
|
||
Reporter | ||
Comment 2•5 years ago
|
||
Reporter | ||
Comment 3•5 years ago
|
||
Reporter | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
Comment 9•5 years ago
|
||
Comment on attachment 9041062 [details] [diff] [review] fix+reftest Review of attachment 9041062 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/forms/nsRangeFrame.cpp @@ +718,5 @@ > > return nsContainerFrame::AttributeChanged(aNameSpaceID, aAttribute, aModType); > } > > +nscoord nsRangeFrame::AutoCrossSize(nscoord aEm) { Please comment this function to state what it returns. @@ +727,5 @@ > + nsPresContext* pc = PresContext(); > + pc->GetTheme()->GetMinimumWidgetSize(pc, this, > + StyleAppearance::RangeThumb, > + &size, &unused); > + minCrossSize = pc->DevPixelsToAppUnits(size.height); On Windows the bounds of the themed thumb is not a square, and depends on whether the range is vertical or horizontal. I think you'll need to check the orientation here.
Assignee | ||
Comment 10•5 years ago
|
||
(In reply to Jonathan Watt [:jwatt] from comment #9)
+nscoord nsRangeFrame::AutoCrossSize(nscoord aEm) {
Please comment this function to state what it returns.
There's a comment in the header file.
On Windows the bounds of the themed thumb is not a square, and depends on
whether the range is vertical or horizontal. I think you'll need to check
the orientation here.
OK, fixed.
Comment 11•5 years ago
|
||
Comment on attachment 9042752 [details] [diff] [review] fix+reftest Review of attachment 9042752 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/forms/nsRangeFrame.h @@ +142,5 @@ > */ > void UpdateForValueChange(); > > private: > + // Return our preferred size in the cross-axis. Can you tag on the end "(the axis perpendicular to the direction of movement of the thumb)", or something like that.
Comment 12•5 years ago
|
||
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9a2965532d7b Ensure that an auto-sized <input type=range> is at least large enough to contain the thumb. r=jwatt
Assignee | ||
Updated•5 years ago
|
Comment 13•5 years ago
|
||
bugherder |
Comment 14•5 years ago
|
||
Is this something which should be considered for Beta approval or can it ride the trains?
Comment 15•5 years ago
|
||
I think it's OK to let this ride with 67. Mats if you feel strongly it will be easy and fine in late beta then do request uplift. Otherwise, 67.
Updated•5 years ago
|
Updated•5 years ago
|
Description
•