Closed Bug 1524590 Opened 1 year ago Closed 4 months ago

Remove JS::CloneFunctionObject

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

These APIs aren't great and are only used by XBL so when we remove that code we should remove these APIs as well.

Priority: -- → P3
Type: enhancement → task
No longer depends on: war-on-xbl
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED

We want to remove JS::CloneFunctionObject. Most tests can use
either cloneAndExecuteScript or evaluate instead.

With XBL gone we don't have any real consumers left. Global scripts can still be
cloned but this removes the ability to clone arbitrary functions.

This also removes the testCloneScript jsapi-test because it's not trivial to rewrite and
I don't think it's testing anything that isn't covered by other tests.

Depends on D52978

See Also: → 1598053
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6388a556b7db
part 1 - Fix or remove tests using 'clone' function. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/1c8b04ce515d
part 2 - Remove JS::CloneFunctionObject and JS shell 'clone' function. r=jorendorff,tcampbell
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.