Closed Bug 1524628 Opened 7 months ago Closed 6 months ago

Race condition in devtools/client/styleeditor/test/browser_styleeditor_new.js

Categories

(DevTools :: Style Editor, defect, P2)

defect

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

Details

Attachments

(1 file)

The waitForFocus() call here doesn't actually wait for anything, in the sense of blocking the rest of the test from running.

As a result, with the patch in bug 1495072 (faster await), this test fails the .hasFocus() assertion on line 68.

I diagnosed this wrong.

The waitForFocus() call does wait for the window to gain focus.

But nothing waits for the editor to gain focus.

Component: General → Style Editor
Priority: -- → P2
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c916eda98b1b
Fix a race condition in a devtools style editor test. r=ntim,yulia,miker.
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Assignee: nobody → jorendorff
You need to log in before you can comment on or make changes to this bug.