Closed
Bug 1524631
Opened 6 years ago
Closed 6 years ago
Implement new declaration editor for the new rules view
Categories
(DevTools :: Inspector: Rules, enhancement, P3)
DevTools
Inspector: Rules
Tracking
(firefox67 fixed)
RESOLVED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
This patch will appear a bit weird if you are testing out the functionality. In this patch, I wanted to implement the logic to add multiple declarations with the new declaration editor. In a follow up patch, we will look into handling focus direction when we commit the input into these editors.
|
|
Assignee | |
Comment 3•6 years ago
|
||
Main logic:
https://searchfox.org/mozilla-central/source/devtools/client/inspector/rules/views/rule-editor.js#554-589
https://searchfox.org/mozilla-central/source/devtools/client/inspector/rules/views/rule-editor.js#599-617
https://searchfox.org/mozilla-central/source/devtools/client/inspector/rules/views/rule-editor.js#528-547
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e354e08d4828
Implement new declaration editor for the new rules view. r=rcaliman
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in
before you can comment on or make changes to this bug.
Description
•