Closed Bug 1524638 Opened 5 years ago Closed 5 years ago

Fix some cases of no error feedback via the folderPane icon, check error feeds again after startup (once).

Categories

(MailNews Core :: Feed Reader, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 67.0

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch errorState.patch (obsolete) — Splinter Review
Assignee: nobody → alta88
Attachment #9040775 - Flags: review?(mkmelin+mozilla)
Attached patch errorState.patchSplinter Review

There is a css rule

treechildren::-moz-tree-image(folderNameCol, closed, hasError),
treechildren::-moz-tree-image(folderNameCol, leaf, hasError) {
  list-style-image: url("chrome://mozapps/skin/extensions/alerticon-error.svg");
  -moz-image-region: rect(0 16px 16px 0);
}

but "leaf" no longer seems valid, so images aren't being shown. but only in some cases. paenglab, any ideas? anyway, removing closed and leaf will make subscribe look the same as folderpane. i had wanted a distinction in subscribe between folder and feed url rows.. but i guess it's is ok.

you can do

gFolderTreeView._tree.view.getCellProperties(28, gFolderTreeView._tree.columns.folderNameCol);

to see properties returned in a folderpane row.

Attachment #9040775 - Attachment is obsolete: true
Attachment #9040775 - Flags: review?(mkmelin+mozilla)
Flags: needinfo?(richard.marti)
Attachment #9040786 - Flags: review?(mkmelin+mozilla)

(In reply to alta88 from comment #2)

but "leaf" no longer seems valid, so images aren't being shown. but only in some cases. paenglab, any ideas? anyway, removing closed and leaf will make subscribe look the same as folderpane. i had wanted a distinction in subscribe between folder and feed url rows.. but i guess it's is ok.

Maybe "leaf" was gone with the de-XBL works. It would be nice, when we had the folder icon. But when this no more works, then I think it's ok like it is now.

Flags: needinfo?(richard.marti)
Comment on attachment 9040786 [details] [diff] [review]
errorState.patch

Review of attachment 9040786 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9040786 - Flags: review?(mkmelin+mozilla) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/34d1e8614042
Fix some cases of no error feedback via the folderPane icon, check error feeds again on startup (once). r=mkmelin

Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 67.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: