Open Bug 1524639 Opened 10 months ago Updated 4 months ago

Cleanup the uses of `basestring` in taskgraph that are used with json/yaml.

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

People

(Reporter: tomprince, Unassigned, NeedInfo)

References

(Blocks 1 open bug)

Details

(Keywords: leave-open)

Attachments

(9 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

By default, pyyaml loads strings as mixed bytes and unicode, depending on whether the string is ascii. Because of this, we have basestring everywhere, which isn't suppored in py3.

Override that behavior, so we can remove most of the references to basestring.

The task definition is loaded via json, so all the strings are going to be
unicode.

Keywords: leave-open
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/8c223c41ceef
[taskgraph] Remove unused `enforce_order` argument to `load_yaml`; r=dustin
https://hg.mozilla.org/integration/autoland/rev/8bd8c850ac06
[taskgraph] Change `load_yaml` to accept any number of path components; r=dustin
https://hg.mozilla.org/integration/autoland/rev/342b88378d5d
[taskgraph] Force yaml to be loaded as unicode; r=dustin
https://hg.mozilla.org/integration/autoland/rev/5594ba0afbee
[taskgraph] Add a helper to `Schema` to allow referencing downstream schema entries; r=dustin
https://hg.mozilla.org/integration/autoland/rev/ad35bb6c3697
[taskgraph] Ensure that actions names are unicode; r=dustin
https://hg.mozilla.org/integration/autoland/rev/75a3f3ad5770
[taskgraph] Refine some docstrings that return `unicode` to indicate that; r=dustin
https://hg.mozilla.org/integration/autoland/rev/13faff410e98
[taskgraph] Only look for unicode in `relativize_datestamps`; r=dustin
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/comm-central/rev/43775b607968
Port bug 1524639 - Update optimization in release-source kinds.  rs=bustage-fix
Attachment #9041608 - Attachment description: Bug 1524639: [taksgraph] Simplify dependency creation in single_dep/multi_dep transforms; r?aki → Bug 1524639: [taksgraph] Simplify dependency creation in single_dep transforms; r?aki
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/autoland/rev/e35136a50450
[taksgraph] Simplify dependency creation in single_dep transforms; r=aki

The leave-open keyword is there and there is no activity for 6 months.
:tomprince, maybe it's time to close this bug?

Flags: needinfo?(mozilla)
You need to log in before you can comment on or make changes to this bug.