1524714 - @ by itself should show all the engine @aliases

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Drew Willcoxon :adw]

In the latest m-c, typing @ by itself shows a blank popup except for a magnifying glass icon for each result. (Up until recently it used to show "@foo -- Search with Foo" for each result. I'm not sure what changed.)

It should show "Search with Foo" for each result.

I'll work on this if no one else does first, but I have some other things first, so I won't assign myself to it yet. Feel free to take before then.

Comment 1

[Drew Willcoxon :adw]

Sorry, that's backwards. Up until recently it showed "Search with Foo", but it should show "@foo -- Search with Foo".

Comment 2

[Mark Banner (:standard8)]

Note: when we fix this, we should also enabled the test in browser_urlbarTokenAlias.js that's currently disabled (already ported, hopefully not too many changes needed).

Comment 3

[Drew Willcoxon :adw]

Thanks Mark.

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1524714 - @ by itself should show all the engine @aliases.

The main part of the corresponding logic in the legacy urlbar is here: https://hg.mozilla.org/mozilla-central/annotate/73a91e84dbec/toolkit/content/widgets/autocomplete.xml#l1964

This patch basically just ports that.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c63ff7601477
@ by itself should show all the engine @aliases. r=mak,dao

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c63ff7601477