1524774 - Intermittent scrolling/frame-scrolling-attr-2.html == scrolling/frame-scrolling-attr-ref.html | image comparison, max difference: 1, number of differing pixels: 1

Status: RESOLVED FIXED

(Core :: Layout, defect, P5)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: ccoroiu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=225624748&repo=mozilla-central

https://queue.taskcluster.net/v1/task/T73MlLBpRO6MKDg7aApruA/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/T73MlLBpRO6MKDg7aApruA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

Comment 1

[Intermittent Failures Robot]

2 failures in 2628 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1
• mozilla-central: 1

Platform breakdown:

• linux64-ccov: 1
• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524774&startday=2019-01-28&endday=2019-02-03&tree=all

Comment 2

[Intermittent Failures Robot]

18 failures in 379 pushes (0.047 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-inbound: 6
• autoland: 10
• mozilla-central: 1
• try: 1

Platform breakdown:

• linux32: 6
• linux64: 12

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524774&startday=2019-02-04&endday=2019-02-04&tree=all

Comment 3

[Andreea Pavel [:apavel]]

Waiting for reply on bug 1524031

Comment 4

[Intermittent Failures Robot]

30 failures in 442 pushes (0.068 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-inbound: 9
• autoland: 17
• mozilla-central: 4

Platform breakdown:

• linux64-ccov: 1
• linux32: 9
• linux64: 20

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524774&startday=2019-02-05&endday=2019-02-05&tree=all

Comment 5

[Intermittent Failures Robot]

23 failures in 478 pushes (0.048 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 2
• autoland: 14
• mozilla-inbound: 6
• try: 1

Platform breakdown:

• linux64: 13
• linux32: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524774&startday=2019-02-06&endday=2019-02-06&tree=all

Comment 6

[Intermittent Failures Robot]

34 failures in 486 pushes (0.07 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 21
• try: 1
• mozilla-inbound: 10
• mozilla-central: 2

Platform breakdown:

• linux32: 11
• linux64: 21
• linux64-ccov: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524774&startday=2019-02-07&endday=2019-02-07&tree=all

Comment 7

[Intermittent Failures Robot]

17 failures in 550 pushes (0.031 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 14
• mozilla-inbound: 1
• try: 1
• mozilla-central: 1

Platform breakdown:

• linux32: 9
• linux64: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524774&startday=2019-02-08&endday=2019-02-08&tree=all

Comment 8

[Intermittent Failures Robot]

142 failures in 2658 pushes (0.053 failures/push) were associated with this bug in the last 7 days.

This is the #7 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 87
• try: 7
• mozilla-inbound: 34
• mozilla-central: 14

Platform breakdown:

• linux32: 52
• linux64: 85
• linux64-ccov: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524774&startday=2019-02-04&endday=2019-02-10&tree=all

Comment 9

[Andrei Ciure[:aciure]]

There are 115 failures associated to this bug in the last 7 days. These are occurring on Linux, asan and debug builds.

:svoisen can you take a look?

Comment 10

[Intermittent Failures Robot]

21 failures in 564 pushes (0.037 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• try: 1
• mozilla-central: 6
• autoland: 6
• mozilla-inbound: 8

Platform breakdown:

• linux64-ccov: 2
• linux32: 6
• linux64: 13

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524774&startday=2019-02-12&endday=2019-02-12&tree=all

Comment 11

[Sean Voisen (:svoisen)]

dholbert: Any thoughts on this?

Comment 12

[Daniel Holbert [:dholbert]]

It looks like a subtle antialiasing difference on the corner of a scrollbar.

Not a user-noticeable issue, and possibly not even our bug (could be an underlying GTK rendering bug).

I'll land a fuzzy annotation to allow for this 1px difference.

Comment 13

[Daniel Holbert [:dholbert]]

Unfortunately this test already has an unrelated "fuzzy-if" rule:

fuzzy-if(asyncPan&&!layersGPUAccelerated,0-140,0-6818) == iframe-scrolling-attr-2.html iframe-scrolling-attr-ref.html

I always have a hard time remembering & reasoning about reftest annotation precedence (there are cases where it doesn't do what you'd expect, particularly when you're mixing fails-if / skip-if with fuzzy-if). But since I'm just adding "fuzzy-if" alongside another fuzzy-if, I'm pretty sure it's straightforward and ordering/precedence doesn't matter.

Comment 14

[Daniel Holbert [:dholbert]]

(I have a patch ready to land on inbound; I'm just waiting for my local rebuild of inbound tip to complete, to sanity-check that the reftest still runs and that I didn't mess up the syntax.)

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d917b008b34
Add fuzzy annotation to allow for subtle 1px difference on scrollbar corner in reftest frame-scrolling-attr-2.html. (no review, test-manifest-tweak only)

Comment 16

[Daniel Holbert [:dholbert]]

This should stop being reported as a failure, but please reopen & needinfo me if there are still somehow instances of this after comment 15 is merged around.

Comment 17

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6d917b008b34

Comment 18

[Intermittent Failures Robot]

20 failures in 469 pushes (0.043 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 3
• try: 2
• autoland: 9
• mozilla-inbound: 6

Platform breakdown:

• linux64: 14
• linux32: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524774&startday=2019-02-13&endday=2019-02-13&tree=all

Comment 19

[Bogdan Tara[:bogdan_tara | bogdant]]

This is still happening.

Recent failure: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=228354274&repo=autoland&lineNumber=2763

[task 2019-02-14T09:00:22.274Z] 09:00:22 INFO - REFTEST TEST-START | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/scrolling/frame-scrolling-attr-2.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/scrolling/frame-scrolling-attr-ref.html
[task 2019-02-14T09:00:22.274Z] 09:00:22 INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/scrolling/frame-scrolling-attr-2.html | 38 / 98 (38%)
[task 2019-02-14T09:00:22.953Z] 09:00:22 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/scrolling/frame-scrolling-attr-2.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/scrolling/frame-scrolling-attr-ref.html | image comparison, max difference: 1, number of differing pixels: 1
[task 2019-02-14T09:00:22.955Z] 09:00:22 INFO - REFTEST IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAAAAmy
[task 2019-02-14T09:00:22.956Z] 09:00:22 INFO - REFTEST IMAGE 2 (REFERENCE): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoC
[task 2019-02-14T09:00:22.956Z] 09:00:22 INFO - REFTEST INFO | Saved log: START file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/scrolling/frame-scrolling-attr-2.html
[task 2019-02-14T09:00:22.960Z] 09:00:22 INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
[task 2019-02-14T09:00:22.962Z] 09:00:22 INFO - REFTEST INFO | Saved log: [CONTENT] FlushRendering generated paint for window data:text/html,<body style='overflow:scroll'>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>X<br>
[task 2019-02-14T09:00:22.963Z] 09:00:22 INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
[task 2019-02-14T09:00:22.964Z] 09:00:22 INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
[task 2019-02-14T09:00:22.966Z] 09:00:22 INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
[task 2019-02-14T09:00:22.967Z] 09:00:22 INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2019-02-14T09:00:22.969Z] 09:00:22 INFO - REFTEST INFO | Saved log: RecordResult fired
[task 2019-02-14T09:00:22.970Z] 09:00:22 INFO - REFTEST TEST-END | file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/scrolling/frame-scrolling-attr-2.html == file:///builds/worker/workspace/build/tests/reftest/tests/layout/reftests/scrolling/frame-scrolling-attr-ref.html

Comment 20

[Daniel Holbert [:dholbert]]

Thanks. That's because I'm silly and annotated the wrong test. (I annotated iframe-scrolling-attr-2.html, with an "i", rather than frame-scrolling-attr-2.html)

Comment 21

[Daniel Holbert [:dholbert]]

Given bug 1525568 (a similar 2px intermittent failure on Mac) and given the existing annotation on the "-1" version of this test, I'm just going to push a non-platform-specific annotation that allows 2px to differ by 1 per color channel).

Comment 22

[Daniel Holbert [:dholbert]]

(waiting on inbound to reopen before I can land the patch.)

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bdfdfcd59ae7
Backed out changeset 6d917b008b34 because it annotated the wrong test
https://hg.mozilla.org/integration/mozilla-inbound/rev/6992c0554ab9
Annotate frame-scrolling-attr-2.html as having 2 slightly fuzzy pixels. (no review, test-annotation-only)

Comment 24

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6992c0554ab9

Comment 25

[Intermittent Failures Robot]

63 failures in 2832 pushes (0.022 failures/push) were associated with this bug in the last 7 days.

This is the #21 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 26
• mozilla-central: 11
• try: 5
• mozilla-inbound: 21

Platform breakdown:

• linux32: 22
• osx-10-10: 1
• linux64-ccov: 3
• linux64: 37

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1524774&startday=2019-02-11&endday=2019-02-17&tree=all