1524823 - Crash in mozilla::EditorSpellCheck::UpdateCurrentDictionary when editting calendar description

Status: RESOLVED INCOMPLETE

(Core :: DOM: Editor, defect, P3)

Description

[Wayne Mery (:wsmwk)]

Looks like this started in Thunderbird 60 https://crash-stats.mozilla.com/signature/?product=Thunderbird&signature=mozilla%3A%3AEditorSpellCheck%3A%3AUpdateCurrentDictionary&date=%3E%3D2018-08-02T23%3A03%3A56.000Z&date=%3C2019-02-02T22%3A03%3A56.000Z#summary

All the crash comments are similar to "putting cursor in the rich text editor for an Outlook calendar event."

This bug is for crash report bp-6c939302-cb93-46fc-a92e-862350190125.

Top 10 frames of crashing thread:

0 libxul.so mozilla::EditorSpellCheck::UpdateCurrentDictionary /build/thunderbird-0Yvt8J/thunderbird-60.4.0+build2/mfbt/RefPtr.h:287
1 libxul.so mozInlineSpellChecker::UpdateCurrentDictionary /build/thunderbird-0Yvt8J/thunderbird-60.4.0+build2/extensions/spellcheck/src/mozInlineSpellChecker.cpp:1940
2 libxul.so mozilla::EditorBase::OnFocus /build/thunderbird-0Yvt8J/thunderbird-60.4.0+build2/editor/libeditor/EditorBase.cpp:5474
3 libxul.so mozilla::EditorEventListener::Focus /build/thunderbird-0Yvt8J/thunderbird-60.4.0+build2/editor/libeditor/EditorEventListener.cpp:1143
4 libxul.so mozilla::CycleCollectedJSContext::CleanupIDBTransactions /build/thunderbird-0Yvt8J/thunderbird-60.4.0+build2/xpcom/ds/nsTArray.h:880
5 libxul.so mozilla::dom::Event::AddRef /build/thunderbird-0Yvt8J/thunderbird-60.4.0+build2/xpcom/base/nsISupportsImpl.h:227
6 libxul.so mozilla::EditorEventListener::HandleEvent /build/thunderbird-0Yvt8J/thunderbird-60.4.0+build2/editor/libeditor/EditorEventListener.cpp:1075
7 libxul.so mozilla::EventListenerManager::HandleEventSubType /build/thunderbird-0Yvt8J/thunderbird-60.4.0+build2/dom/events/EventListenerManager.cpp:1107
8 libxul.so mozilla::EventListenerManager::HandleEventInternal /build/thunderbird-0Yvt8J/thunderbird-60.4.0+build2/dom/events/EventListenerManager.cpp:1276
9 libgobject-2.0.so.0.4800.2 libgobject-2.0.so.0.4800.2@0x11bf8

bp-82039401-eb56-4a40-a8f7-abeb40181018 states "opening comment of a calender entry causes crash"

Comment 1

[[:MakeMyDay]]

I don't think this is releated to Lightning - we don't have a rich-text editor for editing calendar items, while EWS provider has, iirc. The latter seems to be present in most of the profiles (though there is at least one signature without). But EWS is JS only, so a fix would need to happen in TB (or MC) - thus I suggest to move this out of Calendar (probably the editor component) to get some attention.

Comment 2

[Wayne Mery (:wsmwk)]

I think most Thunderbird crashes are the same stack (which are the majority of crashes).

OTOH all three firefox crashes I picked have different stacks, and mostly don't match the Thunderbird stacks.
bp-99e0f91c-8d39-4105-ad2d-066c40190209 firefox 65.0 different
bp-617903b5-4da0-4404-8be5-af0cb0190115 firefox 64.0.2 different

Slightly similar
bp-63fc1d97-dab9-404d-8756-e0cb40181002 TB60.0
0 xul.dll mozilla::EditorSpellCheck::UpdateCurrentDictionary(nsIEditorSpellCheckCallback*) editor/spellchecker/EditorSpellCheck.cpp:751 context
1 xul.dll mozInlineSpellChecker::UpdateCurrentDictionary() extensions/spellcheck/src/mozInlineSpellChecker.cpp:1940 cfi
2 xul.dll mozilla::EditorBase::OnFocus(nsIDOMEventTarget*) editor/libeditor/EditorBase.cpp:5474 cfi
3 xul.dll mozilla::EditorEventListener::Focus(mozilla::InternalFocusEvent*) editor/libeditor/EditorEventListener.cpp:1143 cfi
https://hg.mozilla.org/releases/mozilla-esr60/annotate/ea9412b18ca812f8a480aa28d508298db5fdc531/editor/spellchecker/EditorSpellCheck.cpp#l751
751 nsCOMPtr<nsIDocument> ownerDoc = rootContent->OwnerDoc();

bp-8b589101-07ab-4aaf-882b-cf1db0181215 FX60.3.0esr
0 xul.dll mozilla::EditorSpellCheck::UpdateCurrentDictionary(nsIEditorSpellCheckCallback*) editor/spellchecker/EditorSpellCheck.cpp:743 context
1 xul.dll mozilla::EditorSpellCheck::InitSpellChecker(nsIEditor*, bool, nsIEditorSpellCheckCallback*) editor/spellchecker/EditorSpellCheck.cpp:455 cfi
2 xul.dll mozInlineSpellChecker::SetEnableRealTimeSpell(bool) extensions/spellcheck/src/mozInlineSpellChecker.cpp:783 cfi
https://hg.mozilla.org/releases/mozilla-esr60/annotate/ea9412b18ca812f8a480aa28d508298db5fdc531/editor/spellchecker/EditorSpellCheck.cpp#l743
743 NS_ENSURE_SUCCESS(rv, rv);

Comment 3

[Wayne Mery (:wsmwk)]

This is rare enough that I don't think it is actionable. Only 3 version 68 crashes in the past 6 months.
bp-d81b1295-fa56-497a-99a9-e5db80200303 68.5.0