Closed Bug 1524872 Opened 10 months ago Closed 3 months ago

[RTL] Mirror the search icon on the sidebar

Categories

(Toolkit :: Themes, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla70
Tracking Status
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox67.0.1 --- wontfix
firefox68 --- wontfix
firefox69 --- fixed
firefox70 --- verified

People

(Reporter: itiel_yn8, Assigned: itiel_yn8, Mentored)

References

Details

(Keywords: good-first-bug, rtl)

Attachments

(3 files)

Attached image Before

See Before and After screenshots.

Adding .textbox-search-sign:-moz-locale-dir(rtl), before this code seems to fix it for me.

Attached image After
See Also: → 1497296
Priority: -- → P3

Hi Dão, assuming the fix in comment 0 is the right one, can you please set this bug as good-first-bug?

This doesn't fix the Synced Tabs sidebar as it is implemented differently in sidebar.css.

Blocks: 1497296
Mentor: dao+bmo
Component: Theme → Themes
Flags: needinfo?(dao+bmo)
Keywords: good-first-bug
Product: Firefox → Toolkit
See Also: 1497296
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ba71196f1a4
Mirror the search icon (textbox-search-sign) for RTL r=dao
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Please nominate this for Beta approval if you want this fix to ship in Fx69.

Flags: needinfo?(itiel_yn8)

Comment on attachment 9083136 [details]
Bug 1524872 - Mirror the search icon (textbox-search-sign) for RTL

Beta/Release Uplift Approval Request

  • User impact if declined: Wrong magnifying glass icon direction on search fields for RTL users
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): One line CSS addition to mirror the icon for RTL users only
  • String changes made/needed: None
Flags: needinfo?(itiel_yn8)
Attachment #9083136 - Flags: approval-mozilla-beta?
Status: RESOLVED → VERIFIED

Comment on attachment 9083136 [details]
Bug 1524872 - Mirror the search icon (textbox-search-sign) for RTL

Simple RTL CSS fix. Approved for 69.0b14.

Attachment #9083136 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.