1524893 - Wrong behaviour of <details> <summary>

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Mattis Kohli]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

I created an example here: https://stackoverflow.com/questions/53353524/handle-details-tag-and-checkbox-click-event-with-firefox

Click on a child button element of <summary>

Actual results:

<summary> of <details> showed expanded content.

Expected results:

<summary> of <details> shouldnt show expanded content.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Ting-Yu might recall something about details/summary :)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Probably <summary> should do something like what <label> does?

https://searchfox.org/mozilla-central/rev/152993fa346c8fd9296e4cd6622234a664f53341/dom/html/HTMLLabelElement.cpp#89

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I can fix this one.

Emilio, thanks for the tip :)

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1524893 - Prevent Label and Summary elements from handling click event if clicking on interactive html content.

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1524893 - Override IsInteractiveHTMLContent() for HTMLDetailsElement.

When nsGenericHTMLElement::IsInteractiveHTMLContent() was introduced,
HTMLDetailsElement didn't exist yet. It's better to override
IsInteractiveHTMLContent() for HTMLDetailsElement than check the details
tag in its parent class.

Depends on D18791

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2336e360977
Prevent Label and Summary elements from handling click event if clicking on interactive html content. r=smaug
https://hg.mozilla.org/integration/autoland/rev/4d0958fba8db
Override IsInteractiveHTMLContent() for HTMLDetailsElement. r=smaug

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a2336e360977
https://hg.mozilla.org/mozilla-central/rev/4d0958fba8db