1524902 - odr-violation in util_gtest

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P4)

Description

[Martin Thomson [:mt:]]

This came from an unrelated change:

/home/worker/dist/Debug/bin/certutil -N -d /home/worker/tests_results/security/localhost.1/util_gtest --empty-password
executing util_gtest
=================================================================
==414==ERROR: AddressSanitizer: odr-violation (0x08b54a80):
  [1] size=16 'SEC_SequenceOfAnyTemplate' ../../lib/util/secasn1d.c:3149:24
  [2] size=16 'SEC_SequenceOfAnyTemplate' ../../lib/util/secasn1d.c:3149:24
These globals were registered at these points:
  [1]:
    #0 0x8142bb4  (/home/worker/dist/Debug/bin/util_gtest+0x8142bb4)
    #1 0xf5aa661a  (/home/worker/dist/Debug/lib/libnssutil3.so+0x3d61a)

  [2]:
    #0 0x8142bb4  (/home/worker/dist/Debug/bin/util_gtest+0x8142bb4)
    #1 0x895133a  (/home/worker/dist/Debug/bin/util_gtest+0x895133a)

==414==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0
SUMMARY: AddressSanitizer: odr-violation: global 'SEC_SequenceOfAnyTemplate' at ../../lib/util/secasn1d.c:3149:24
==414==ABORTING

I am surprised that this is only surfacing now. It seems like it is down to static linking problems.

Comment 1

[Martin Thomson [:mt:]]

Attachment: Bug 1524902 - Reduce dependencies for util_gtests, r?jcj

util_gtests shouldn't need to link so much of NSS.

Comment 2

[Martin Thomson [:mt:]]

https://treeherder.mozilla.org/#/jobs?repo=nss-try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunning%2Cpending%2Crunnable&classifiedState=unclassified&revision=3011fe2d1ec493b3ff3fa56c161914ec1c5ea34a

Comment 3

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/dcf1c32bd23244692b5726e0c9a60e2657ef5376

Comment 4

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/b5dd5901aef3f33de57206cfa8126e52cd0a9538 -- because try doesn't run modular builds and I forgot to scrub for unused #includes.