Use color-variables for the agenda items in the today pane
Categories
(Calendar :: General, enhancement)
Tracking
(Not tracked)
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(5 files, 1 obsolete file)
20.04 KB,
image/png
|
Details | |
11.26 KB,
image/png
|
Details | |
9.10 KB,
patch
|
Paenglab
:
review+
pmorris
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
9.11 KB,
patch
|
Details | Diff | Splinter Review | |
8.99 KB,
patch
|
jorgk-bmo
:
approval-calendar-esr+
|
Details | Diff | Splinter Review |
The agenda items in the today pane are hard coded and can't use system colours or colours that match to the dark theme.
We should use variable to be able to set the needed colours depending of themes.
Assignee | ||
Comment 1•5 years ago
|
||
I made the all-day items in the today-pane looking like in the month view with the border. The "Today", "Tomorrow" and "Upcoming" headers have now a dotted border too to separate them when not items are shown and also give the first items on top after the headers.
Comment 2•5 years ago
|
||
Comment on attachment 9103065 [details] [diff] [review] 1524921-today-pane.patch Review of attachment 9103065 [details] [diff] [review]: ----------------------------------------------------------------- Looks good overall. Dark theme is definitely improved. I noticed a couple of things. When looking at a day that's not today or tomorrow, it looks like there's a thicker dotted border below the day heading (i.e. "Wednesday October 23, 2019"). I suspect that more than one dotted border is being drawn, one right on top of the other. So that's probably something you'd want to address either here or in a follow-up. The other thing I noticed seems unrelated to this patch. After clicking forward and back through a few days, the toggle to open and close the "Tomorrow" and "Upcoming" sections stops working. The little arrow changes direction, but the panel doesn't close. I'll file a separate bug for that.
Comment 3•5 years ago
|
||
Filed bug 1590506 for the toggle issue.
Assignee | ||
Comment 4•5 years ago
|
||
I don't see this double border. Upscaled screenshot under Linux.
Assignee | ||
Updated•5 years ago
|
Comment 5•5 years ago
|
||
It only shows up when you are looking at a day that is not today. See screenshot. It's pretty subtle in the default theme, but easier to notice in the dark theme.
Assignee | ||
Comment 6•5 years ago
|
||
Didn't knew that this appearance when I change the date in the today-pane. Fixed.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/dd27120c0e4d
Make the today-pane richlistitems themeable through variables. r=pmorris
Updated•5 years ago
|
Updated•5 years ago
|
Comment 9•5 years ago
|
||
TB 71 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/f2111552b87430e6c217b03ff405646bef4ee5e2
Comment 10•5 years ago
|
||
Comment on attachment 9103366 [details] [diff] [review] 1524921-today-pane.patch That patch doesn't apply to ESR. And there are more problems than I'd like to rebase myself.
Comment 12•5 years ago
|
||
Comment on attachment 9104020 [details] [diff] [review] 1524921-today-pane-ESR.patch Transferring previously granted approval. a=pmorris
Comment 13•5 years ago
•
|
||
There's something wrong here. Looks like the names of those richlistitems have changed. We have on trunk:
agenda-allday-richlistitem - https://searchfox.org/comm-central/search?q=agenda-allday-richlistitem&case=false®exp=false&path=
agenda-richlistitem - https://searchfox.org/comm-central/search?q=agenda-richlistitem&case=false®exp=false&path=
agenda-richlist-item - https://searchfox.org/comm-central/search?q=agenda-richlist-item&case=false®exp=false&path=
agenda-header-richlistitem - https://searchfox.org/comm-central/search?q=agenda-header-richlistitem&case=false®exp=false&path=
agenda-richlist-item looks wrong to me. Whoever renamed agenda-richlist-item to agenda-richlistitem forgot some. One is corrected here:
https://hg.mozilla.org/comm-central/rev/dd27120c0e4d#l3.59
On ESR 68 I have: agenda-allday-richlist-item, agenda-richlist-item and agenda-header-richlist-item. So although it's not consistent, it's at least not wrong. EDIT: It is consistent. EDIT again: Sorry, the patch adds: agenda-allday-richlistitem.
Comment 14•5 years ago
|
||
Comment on attachment 9104020 [details] [diff] [review] 1524921-today-pane-ESR.patch Review of attachment 9104020 [details] [diff] [review]: ----------------------------------------------------------------- ::: calendar/base/themes/common/today-pane.css @@ +300,5 @@ > display: block; > } > > +richlistitem[is="agenda-richlist-item"], > +richlistitem[is="agenda-allday-richlistitem"] { This doesn't look right. On 68 it's always richlist-item.
Comment 15•5 years ago
|
||
This should be the correct ESR version.
Comment 16•5 years ago
|
||
TB 68.2.1 / Cal 7.0:
https://hg.mozilla.org/releases/comm-esr68/rev/90ad3dd1dc1160a3b8bdc4926cb8bef2ea3dcfcb
Landed the corrected patch. Someone still needs to check trunk for:
https://searchfox.org/comm-central/search?q=agenda-richlist-item&case=false®exp=false&path=
Description
•