[boil-all-the-oceans] Support local.get/set and global.get/set syntax

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: lth, Assigned: lth, Mentored)

Tracking

(Blocks 1 bug, {dev-doc-needed, good-first-bug})

unspecified
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

Apparently local.get/set and global.get/set is the new new thing in the WAT world. Easy enough to add interpretation of that syntax to WasmTextToBinary; a bit more work to change all the test cases.

We probably want to cover this in our coverage of the WAT format on MDN.

Keywords: dev-doc-needed
Assignee

Updated

4 months ago
Blocks: 1527871
Assignee

Updated

4 months ago
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
Assignee

Comment 2

4 months ago

I've only added support for these, renamed in a couple of error messages and a few
test cases, not renamed all the uses, because there are so many. Will file followup
bugs for that work, but it won't be urgent.

Note, wabt no longer recognizes get_local et al, it requires local.get etc. But
we should remain backward compatible for a long while still.

Comment 3

4 months ago
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b79be6791cfa
Support local.get, local.set, global.get, global.set.  r=bbouvier

Comment 4

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.