1524923 - [boil-all-the-oceans] Support local.get/set and global.get/set syntax

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Lars T Hansen [:lth]]

Apparently local.get/set and global.get/set is the new new thing in the WAT world. Easy enough to add interpretation of that syntax to WasmTextToBinary; a bit more work to change all the test cases.

Comment 1

[Chris Mills [:cmills]]

We probably want to cover this in our coverage of the WAT format on MDN.

Comment 2

[Lars T Hansen [:lth]]

Attachment: Bug 1524923 - Support local.get, local.set, global.get, global.set. r?bbouvier

I've only added support for these, renamed in a couple of error messages and a few
test cases, not renamed all the uses, because there are so many. Will file followup
bugs for that work, but it won't be urgent.

Note, wabt no longer recognizes get_local et al, it requires local.get etc. But
we should remain backward compatible for a long while still.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b79be6791cfa
Support local.get, local.set, global.get, global.set.  r=bbouvier

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/b79be6791cfa