Closed Bug 1524923 Opened 1 year ago Closed 1 year ago

[boil-all-the-oceans] Support local.get/set and global.get/set syntax

Categories

(Core :: Javascript: WebAssembly, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: lth, Assigned: lth, Mentored)

References

Details

(Keywords: dev-doc-needed, good-first-bug)

Attachments

(1 file)

Apparently local.get/set and global.get/set is the new new thing in the WAT world. Easy enough to add interpretation of that syntax to WasmTextToBinary; a bit more work to change all the test cases.

We probably want to cover this in our coverage of the WAT format on MDN.

Keywords: dev-doc-needed
Blocks: 1527871
Assignee: nobody → lhansen
Status: NEW → ASSIGNED

I've only added support for these, renamed in a couple of error messages and a few
test cases, not renamed all the uses, because there are so many. Will file followup
bugs for that work, but it won't be urgent.

Note, wabt no longer recognizes get_local et al, it requires local.get etc. But
we should remain backward compatible for a long while still.

Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b79be6791cfa
Support local.get, local.set, global.get, global.set.  r=bbouvier
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.