1524976 - Lookup TabParent by TabParent::GetFocused() in EventStateManager::DoContentCommandEvent()

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Henri Sivonen (:hsivonen)]

EventStateManager::DoContentCommandEvent(), in the case of pasting into a content process, obtain the focused LayersId (see bug 1524236), use TabParent::GetTabParentFromLayersId() with that LayersId to find the TabParent.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1524976 - Lookup TabParent by TabParent::GetFocused() in EventStateManager::DoContentCommandEvent().

Depends on D23634

Comment 2

[Henri Sivonen (:hsivonen)]

How do I test this without an old Sun keyboard?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Henri Sivonen (:hsivonen) from comment #2)

How do I test this without an old Sun keyboard?

I don't know. It's used only on macOS, but I don't know how to kick it. How about to write a test like this?

Comment 4

[Henri Sivonen (:hsivonen)]

(In reply to Masayuki Nakano [:masayuki] (JST, +0900) from comment #3)

(In reply to Henri Sivonen (:hsivonen) from comment #2)

How do I test this without an old Sun keyboard?

I don't know. It's used only on macOS, but I don't know how to kick it. How about to write a test like this?

Thanks. This test passes locally. Let's see if it passes on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7942b4a023202d36f30f435beb8574b44ebc4af1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa59ec8e0542
Lookup TabParent by TabParent::GetFocused() in EventStateManager::DoContentCommandEvent(). r=masayuki

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/aa59ec8e0542