Closed
Bug 1525091
Opened 4 years ago
Closed 4 years ago
[about:addons] Include theme previews in HTML views
Categories
(Toolkit :: Add-ons Manager, enhancement, P1)
Toolkit
Add-ons Manager
Tracking
()
VERIFIED
FIXED
mozilla68
People
(Reporter: mstriemer, Assigned: mstriemer)
References
Details
(Whiteboard: [feature-scope])
Attachments
(3 files)
The HTML theme views should have theme previews included with them.
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Whiteboard: [feature-scope]
Updated•4 years ago
|
Priority: P2 → P1
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → mstriemer
Assignee | ||
Comment 1•4 years ago
|
||
Fluent strings load asynchronously, so some text will be empty until that
happens. Once the strings load the page will shift down as the elements
gain the height of the text. Ensure there's always text in the add-on
cards so their height won't change (or at least it's reduced) once
strings load.
Assignee | ||
Comment 2•4 years ago
|
||
Updated•4 years ago
|
Summary: Include theme previews in HTML views → [about:addons] Include theme previews in HTML views
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cf8d76b471b0 Part 1: Avoid height change on string load in HTML about:addons r=jaws,Gijs,zbraniecki https://hg.mozilla.org/integration/autoland/rev/f60d8ef4388d Part 2: Theme previews in HTML about:addons r=jaws
Comment 4•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cf8d76b471b0
https://hg.mozilla.org/mozilla-central/rev/f60d8ef4388d
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Updated•4 years ago
|
Flags: in-testsuite+
This issue is verified as fixed on Firefox 68.0a1 (20190414214746) under Win 7 64-bit and Mac OS X 10.14.1.
The window from the top is Firefox 68.0a1 (20190414214746) and the window from the bottom is Firefox 67.0b10 (20190411084603).
Please see the attached screenshot.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•