[about:addons] Include theme previews in HTML views

VERIFIED FIXED in Firefox 68

Status

()

enhancement
P1
normal
VERIFIED FIXED
7 months ago
4 months ago

People

(Reporter: mstriemer, Assigned: mstriemer)

Tracking

(Blocks 1 bug)

Trunk
mozilla68
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox67 wontfix, firefox68 verified)

Details

(Whiteboard: [feature-scope])

Attachments

(3 attachments)

The HTML theme views should have theme previews included with them.

Blocks: 1505924
No longer depends on: 1514316
Whiteboard: [feature-scope]
Blocks: 1531964
No longer blocks: 1531964
Blocks: 1533795
No longer blocks: 1505924
Priority: P2 → P1
Assignee: nobody → mstriemer

Fluent strings load asynchronously, so some text will be empty until that
happens. Once the strings load the page will shift down as the elements
gain the height of the text. Ensure there's always text in the add-on
cards so their height won't change (or at least it's reduced) once
strings load.

Summary: Include theme previews in HTML views → [about:addons] Include theme previews in HTML views
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf8d76b471b0
Part 1: Avoid height change on string load in HTML about:addons r=jaws,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/f60d8ef4388d
Part 2: Theme previews in HTML about:addons r=jaws
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: in-testsuite+
Posted image Bug1525091.png

This issue is verified as fixed on Firefox 68.0a1 (20190414214746) under Win 7 64-bit and Mac OS X 10.14.1.

The window from the top is Firefox 68.0a1 (20190414214746) and the window from the bottom is Firefox 67.0b10 (20190411084603).

Please see the attached screenshot.

Status: RESOLVED → VERIFIED
See Also: → 1546123
You need to log in before you can comment on or make changes to this bug.