1525091 - [about:addons] Include theme previews in HTML views

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P1)

Description

[Mark Striemer [:mstriemer]]

The HTML theme views should have theme previews included with them.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1525091 - Part 1: Avoid height change on string load in HTML about:addons r?jaws

Fluent strings load asynchronously, so some text will be empty until that
happens. Once the strings load the page will shift down as the elements
gain the height of the text. Ensure there's always text in the add-on
cards so their height won't change (or at least it's reduced) once
strings load.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1525091 - Part 2: Theme previews in HTML about:addons r?jaws

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf8d76b471b0
Part 1: Avoid height change on string load in HTML about:addons r=jaws,Gijs,zbraniecki
https://hg.mozilla.org/integration/autoland/rev/f60d8ef4388d
Part 2: Theme previews in HTML about:addons r=jaws

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cf8d76b471b0
https://hg.mozilla.org/mozilla-central/rev/f60d8ef4388d

Comment 5

[CosminB]

Attachment: Bug1525091.png

This issue is verified as fixed on Firefox 68.0a1 (20190414214746) under Win 7 64-bit and Mac OS X 10.14.1.

The window from the top is Firefox 68.0a1 (20190414214746) and the window from the bottom is Firefox 67.0b10 (20190411084603).

Please see the attached screenshot.