Closed
Bug 1525113
Opened 5 years ago
Closed 5 years ago
Disable crashy Binscope checks
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
1.88 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
A patch from baku got backed out for making Binscope crash on xul.dll during the ATLVersionCheck and VB6Check. The crash is in ancient msdia120 and smells of a threading or memory safety issue (oh the irony) since the crashing address is sometimes valid by the time my debugger steps in.
Binscope is deprecated anyway and the right long term fix is to stop using it: bug 1450088.
In the meantime let's just stop doing those checks. I'm not especially worried about accidentally introducing a VB6 dependency.
Picking Nathan who was the most recent reviewer for autobinscope.py.
Assignee: nobody → dmajor
Attachment #9041270 -
Flags: review?(nfroyd)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9041270 [details] [diff] [review] Bug 1525113: Disable two crashy Binscope checks. Review of attachment 9041270 [details] [diff] [review]: ----------------------------------------------------------------- Sure.
Attachment #9041270 -
Flags: review?(nfroyd) → review+
Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9b25ede0a1d3 Disable two crashy Binscope checks. r=froydnj
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•