Closed Bug 1525155 Opened 1 year ago Closed 1 year ago

ContentBlocking catch-all categories have inconsistent values

Categories

(GeckoView :: General, enhancement)

enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: esawin, Assigned: esawin)

References

Details

Attachments

(1 file)

With bug 1499214 we've introduced a combined Content Blocking API.
However, the new catch-all resource category values, AT_ALL and SB_ALL have inconsistent values compared to the individual AT_* and SB_* constants they cover.

This does not have an effect on the blocklist selection, but breaks the API symmetry, e.g., with setCategories(AT_ALL), getCategories() does not return AT_ALL.

Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10a88ee4b8ac
[1.0] Use explicit constants to set catch-all values. r=geckoview-reviewers,snorp
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.