1525218 - Use minidump_stackwalk toolchain artifacts instead of tooltool packages

Status: RESOLVED FIXED

(Testing :: General, enhancement, P3)

Description

[Mike Hommey [:glandium]]

Bug 1391408 added toolchain tasks that build minidump_stackwalk for linux, osx and win32, corresponding to the tooltool packages we are currently using.

Bug 1519353 imported the changes we had in those tooltool packages against the in-tree version, so that the results of the toolchain tasks is now equivalent.

Those toolchain tasks artifacts should now be used instead of the tooltool packages for tests on automation.

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Joel - is this your department?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

:ahal, can you put this in your queue- My only question here would be android as we have different needs there and will probably need to support both models. Assuming this works on android, it would reduce some headaches on android hardware at bitbar since we currently rebuild docker images to include tooltool artifacts.

Comment 3

[Mike Hommey [:glandium]]

We presumably don't need minidump_stackwalk running on android itself. Isn't it supposed to be run by the harness on the linux host?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

it is run on the linux hosts, not sure if we need to do something different as the stack comes from android

Comment 5

[Bob Clary [:bc] (inactive)]

fwiw, aerickson is testing a new bitbar image without the prepopulated tooltool cache since bitbar has added --dns to the container start command. It looks promising and we should know for sure later today.

Comment 6

[Bob Clary [:bc] (inactive)]

The image passed testing and is now in production. We no longer cache the tooltool downloads in the bitbar image.

Comment 7

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Android should need no special treatment: It just uses the linux64 minidump_stackwalk.

Comment 8

[Mike Hommey [:glandium]]

I stumbled upon how to do it while looking for an answer to bug 1543624 comment 2.

Comment 9

[Andrew Halberstadt [:ahal]]

Sorry, never got a chance to look at this and it's not clear that it'll become a top priority for me anytime soon. If glandium doesn't end up getting to it first, let's leave it in our normal triage process (P3 seems reasonable for now, though feel free to bump to P2).

Comment 10

[Mike Hommey [:glandium]]

I actually have a patch already, but it's blocked on bug 1557614.

Comment 11

[Mike Hommey [:glandium]]

Attachment: Bug 1525218 - Use minidump_stackwalk toolchain artifacts instead of tooltool packages.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb4b265deb5e
Use minidump_stackwalk toolchain artifacts instead of tooltool packages. r=froydnj

Comment 13

[Mike Hommey [:glandium]]

Attachment: Bug 1525218 - Fixup for xpcshell tests fetches.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c66ecb1f66c
Fixup for xpcshell tests fetches.

Comment 15

[Mike Hommey [:glandium]]

Attachment: Bug 1525218 - More fixups for test fetches.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76036ce90611
More fixups for test fetches.

Comment 17

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/eb4b265deb5e
https://hg.mozilla.org/mozilla-central/rev/9c66ecb1f66c

Comment 18

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/76036ce90611

Comment 19

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for breaking raptor speedometer tests on mobile repositories (e.g. fenix, reference-browser) due to missing minidump_stackwalk (bug 1609754) on request from igoldan:
https://hg.mozilla.org/integration/autoland/rev/52c8276357213c93e91657b6d0ce6002e1e05af3

Comment 20

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/ed984981596e328cbd17d5155d27c410ad4dacb8

Comment 21

[Tom Prince [:tomprince]]

I just discovered that builds also are using a mix of tooltool and trying to use build/tools (but that repo isn't checked out so they point to a non-existant file).

https://searchfox.org/mozilla-central/search?q=MINIDUMP_STACKWALK&path=testing%2Fmozharness%2Fconfigs%2Fbuilds

Comment 22

[Mike Hommey [:glandium]]

Mmmmm how come I didn't alter those?

Comment 23

[Mike Hommey [:glandium]]

(In reply to Tom Prince [:tomprince] from comment #21)

I just discovered that builds also are using a mix of tooltool and trying to use build/tools (but that repo isn't checked out so they point to a non-existant file).

https://searchfox.org/mozilla-central/search?q=MINIDUMP_STACKWALK&path=testing%2Fmozharness%2Fconfigs%2Fbuilds

Moved that part to bug 1613561 because it doesn't actually depends on this bug.

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7dcafc398876
Use minidump_stackwalk toolchain artifacts instead of tooltool packages. r=froydnj

Comment 25

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7dcafc398876