1525278 - Assert that AudioStream is not errored when volume is set

Status: RESOLVED INVALID

(Core :: Audio/Video: Playback, defect, P2)

Description

[Alex Chronopoulos [:achronop]]

Similar fix for error case.

+++ This bug was initially created as a clone of Bug #1518443 +++

This came up from the investigation of bug 1481244. The problem there is that the cubeb set volume method is called when output audiounit does not exist. If that happens because AudioStream::SetVolume is called after the AudioStream has closed it will be a problem in gecko side. I am pushing this patch to check if that's the case.

Comment 1

[Alex Chronopoulos [:achronop]]

Phabricator did not post the review:
https://phabricator.services.mozilla.com/D18682

Comment 2

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1525278 - Assert AudioStream is not errored when SetVolume is called. r?jya

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7713efeb5f1
Assert AudioStream is not errored when SetVolume is called. r=jya

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b7713efeb5f1

Comment 5

[Alex Chronopoulos [:achronop]]

In Bug 1528190 we are hitting the diagnostic assert added in the patch above. This issue reopened to backout the diagnostic assert. The fix for the crash will be landed with Bug 1481244.

Comment 6

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1525278 - Backed out b7713efeb5f1 which contains only diagnostic asserts. r?jya

Comment 7

[Razvan Maries]

Backed out as jya's request.

Backout: https://hg.mozilla.org/integration/autoland/rev/cbe6355fcd801c87a1ee6503110a3742b2dcd0bc

Comment 8

[Alex Chronopoulos [:achronop]]

This issue created to land diagnostics. We have taken the results and backed out the diagnostics. I am closing.