Closed Bug 1525326 Opened 5 years ago Closed 5 years ago

Track Changes - (cleanup in Firefox 70) Remove hashing methods for rule and source identifiers

Categories

(DevTools :: Inspector: Changes, enhancement, P3)

enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Iteration:
70.1 - Jul 8 - 21
Tracking Status
firefox70 --- fixed

People

(Reporter: rcaliman, Assigned: rcaliman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The patch for Bug 1525238 introduced the id attribute for rules and sources tracked on the server. This replaces the need to build custom hashes to uniquely identify rules and sources via getRuleHash() and getSourceHash:

https://searchfox.org/mozilla-central/rev/9eb30227b21e0aa40d51d9f9b08bb0b113c5fadb/devtools/client/inspector/changes/utils/changes-utils.js#9-57

However, since we support backwards compatibility for 2-3 versions of the server, we need to ensure the client doesn't break when using an older server which does not implement the id property.

As of Firefox 70, we can remove the fallbacks which attempt to support the old hashing methods:
https://searchfox.org/mozilla-central/rev/9eb30227b21e0aa40d51d9f9b08bb0b113c5fadb/devtools/client/inspector/changes/reducers/changes.js#7,80,199-200

The patch for Bug 1525238 will not go in. No need to cleanup.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Assignee: nobody → rcaliman
Target Milestone: Future → Firefox 70

Since Firefox 67 tracked changes have unique identifiers as follows:

  • ruleId => StyleRuleActor.actorID
  • sourceId => StylesheetActor.actorID

Given that we're at Firefox 70 and beyond the window where we support connecting to servers older than 3 versions, this patch removes the backwards compatibility provided by methods to generate unique ids based on attributes of the rule and stylesheet for the tracked change.

Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b001732ad54f
Remove backwards compatibility for custom unique ids for rules and stylesheets. r=gl
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: