Track Changes - (cleanup in Firefox 70) Remove hashing methods for rule and source identifiers
Categories
(DevTools :: Inspector: Changes, enhancement, P3)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The patch for Bug 1525238 introduced the id
attribute for rules and sources tracked on the server. This replaces the need to build custom hashes to uniquely identify rules and sources via getRuleHash()
and getSourceHash
:
However, since we support backwards compatibility for 2-3 versions of the server, we need to ensure the client doesn't break when using an older server which does not implement the id
property.
As of Firefox 70, we can remove the fallbacks which attempt to support the old hashing methods:
https://searchfox.org/mozilla-central/rev/9eb30227b21e0aa40d51d9f9b08bb0b113c5fadb/devtools/client/inspector/changes/reducers/changes.js#7,80,199-200
Assignee | ||
Comment 1•5 years ago
|
||
The patch for Bug 1525238 will not go in. No need to cleanup.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Since Firefox 67 tracked changes have unique identifiers as follows:
- ruleId => StyleRuleActor.actorID
- sourceId => StylesheetActor.actorID
Given that we're at Firefox 70 and beyond the window where we support connecting to servers older than 3 versions, this patch removes the backwards compatibility provided by methods to generate unique ids based on attributes of the rule and stylesheet for the tracked change.
Assignee | ||
Comment 3•5 years ago
|
||
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b001732ad54f Remove backwards compatibility for custom unique ids for rules and stylesheets. r=gl
Comment 5•5 years ago
|
||
bugherder |
Description
•