1525346 - Fix the cross-compartment bug in MaybeCrossOriginObject::enumerate

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

This is what caused the failures when I tried to push bug 1471496.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1525346. Fix the cross-compartment bug in MaybeCrossOriginObject::enumerate. r=jandem

Comment 2

[Boris Zbarsky [:bzbarsky]]

Many thanks to jandem and jonco for figuring this out.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfefd2d4d63f
Fix the cross-compartment bug in MaybeCrossOriginObject::enumerate.  r=jandem

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset dfefd2d4d63f (Bug 1525346) for failures in test_bug862380.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=dfefd2d4d63f8f2cdeb57e6ee16a8c31c4f54447&selectedJob=226289686

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226289686&repo=autoland&lineNumber=4678
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=226292336&repo=autoland&lineNumber=21130

Backout: https://hg.mozilla.org/integration/autoland/rev/08618a585e6612832b70fbe69403acfbe742f4b6

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d1421bf2ade
Fix the cross-compartment bug in MaybeCrossOriginObject::enumerate.  r=jandem

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a96986fa4704
followup.  Fix the assertEnteredPolicy failure to reopen the CLOSED TREE.

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/1d1421bf2ade
https://hg.mozilla.org/mozilla-central/rev/a96986fa4704