Closed Bug 1525386 Opened 8 months ago Closed 8 months ago

xpcshell test improvements to make regenerating certificates more straightforward

Categories

(Core :: Security: PSM, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: keeler, Assigned: keeler)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

In bug 1435644 all the test certificates expired again. Regenerating them was almost as simple as running pycert on all of the certspec files, but there were a few test changes that needed to happen as well. I suspect we can change these tests so that they don't need to change when we regenerate certificates.

This includes but might not be limited to tests that use:

browser/base/content/test/general/ssl_error_reports.sjs (ok this isn't for an xpcshell test but still)
security/manager/ssl/tests/unit/test_baseline_requirements/ca.pem
security/manager/ssl/tests/unit/test_startcom_wosign/StartComCA.pem
security/manager/ssl/tests/unit/test_startcom_wosign/WoSignCA.pem

As well as these specific tests:

security/manager/ssl/tests/unit/test_x509.js
security/manager/ssl/tests/unit/test_content_signing.js
security/manager/ssl/tests/unit/test_cert_chains.js

(Also the test_blocklist_signatures test certs should be checked in to the tree rather than regenerated each build.)

No longer depends on: 1435858

I guess I meant bug 1525191 in the description there.

In bug 1525191, the test certificates expired again. While regenerating them is
almost as simple as running a script, there were some manual test changes that
had to happen to get the tests passing again. This patch fixes up those tests so
that they shouldn't need changing the next time we regenerate the certificates.

Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0052ee18f2c8
improvements to some tests so they don't break when certificates are regenerated r=jcj
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.